Skip to content

Fix GC Race condition with tests #27652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 1 commit into from
Feb 9, 2025
Merged

Fix GC Race condition with tests #27652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/Controls/tests/Core.UnitTests/TestClasses/TestWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@
using System.Collections.Generic;
using System.Linq;
using System.Runtime.CompilerServices;
using System.Text;
using System.Threading.Tasks;

namespace Microsoft.Maui.Controls.Core.UnitTests
{
public class TestWindow : Window
{
// Because the relationship from Window => Application is a weakreference
// we need to retain a reference to the Application so it doesn't get GC'd
TestApp _app;
public TestWindow()
{

Expand All @@ -24,12 +25,10 @@ protected override void OnPropertyChanged([CallerMemberName] string propertyName
if (propertyName == PageProperty.PropertyName &&
Parent == null)
{
var app = new TestApp(this);
_ = (app as IApplication).CreateWindow(null);
_app = new TestApp(this);
_ = (_app as IApplication).CreateWindow(null);
}
}


}

public static class TestWindowExtensions
Expand Down