[Android] Fix crash starting the swipe on SwipeView inside CollectionView#27669
Merged
jfversluis merged 3 commits intomainfrom Feb 25, 2025
Merged
[Android] Fix crash starting the swipe on SwipeView inside CollectionView#27669jfversluis merged 3 commits intomainfrom
jfversluis merged 3 commits intomainfrom
Conversation
jsuarezruiz
added
t/bug
Contributor
|
@jsuarezruiz Since the crash is reproducing randomly on the Android platform in a Windows machine, we are unable to test the fix precisely. However, after applying the fix, the issue did not reproduce in multiple attempts. Additionally, we ensured that without the fix, the issue was reproduced in random scenarios. So, hope this PR will resolve the issue |
Contributor
Author
|
/rebase |
github-actions
bot
force-pushed
the
fix-26328
branch
from
481de5a to
ea5ac61
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/Controls/tests/TestCases.HostApp/Issues/Issue26328.xaml: Language not supported
Comments suppressed due to low confidence (3)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue26328.cs:17
- The test case should verify that the swipe items are correctly removed and that the crash is fixed.
[Category(UITestCategories.SwipeView)]
src/Core/src/Platform/Android/MauiSwipeView.cs:529
- Ensure that the behavior introduced by the null check for
_contentView.IsDisposed()is covered by tests.
if (_contentView == null || _contentView.IsDisposed() || _actionView != null)
src/Core/src/Platform/Android/MauiSwipeView.cs:548
- Ensure that the behavior introduced by the null check for
swipeItemis covered by tests.
AView? swipeItem = item?.ToPlatform(MauiContext);
jfversluis
approved these changes
Feb 25, 2025
tj-devel709
pushed a commit
that referenced
this pull request
Mar 3, 2025
…View (#27669) * Added repro sample * Added UITest * Some changes based on the issue attached log (cannot repro the issue)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix crash starting the swipe on SwipeView inside CollectionView.
I have not been able to reproduce the crash on emulators or device (Pixel 8 Android 15) so I have applied changes based on reviewing the log attached to the issue.
Draft PR until we can reproduce it.
Issues Fixed
Fixes #26328