[Testing] Fix for flaky UITests in CI that occasionally fail - 3

src/Controls/tests/TestCases.HostApp/Issues/Issue19152.xaml

@@ -2,12 +2,13 @@
 <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
              xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
              x:Class="Maui.Controls.Sample.Issues.Issue19152"
+             xmlns:local="clr-namespace:Maui.Controls.Sample"
              Title="Issue19152">
     <ScrollView>
         <VerticalStackLayout
         Padding="30,0"
         Spacing="25">
-            <Entry Background="White" AutomationId="entry" x:Name="entry" TextColor="Blue" Text="Entry Text" ClearButtonVisibility="WhileEditing"/>
+            <local:UITestEntry Background="White" AutomationId="entry" x:Name="entry" TextColor="Blue" Text="Entry Text" ClearButtonVisibility="WhileEditing" IsSpellCheckEnabled="False" IsCursorVisible="False"/>
             <Button AutomationId="button"
             x:Name="button"
             Text="Click me" 

src/Controls/tests/TestCases.Shared.Tests/Tests/CarouselViewUITests.cs

@@ -10,8 +10,7 @@ public class CarouselViewUITests : UITest
 	{
 		const string CarouselViewGallery = "CarouselView Gallery";
 
-		public CarouselViewUITests(TestDevice device)
-			: base(device)
+		public CarouselViewUITests(TestDevice device): base(device)
 		{
 		}
 
@@ -25,19 +24,18 @@ public override void TestSetup()
 
 		[Test]
 		[Category(UITestCategories.CarouselView)]
-		public async Task CarouselViewSetPosition()
+		public void CarouselViewSetPosition()
 		{
-			await Task.Delay(2000);
+
 			App.WaitForElement("lblPosition");
-			await Task.Delay(3000);
+
 			CheckLabelValue("lblPosition", "3");
 		}
 
 		[Test]
 		[Category(UITestCategories.CarouselView)]
-		public async Task CarouselViewGoToNextCurrentItem()
+		public void CarouselViewGoToNextCurrentItem()
 		{
-			await Task.Delay(2000);
 			int indexToTest = 3;
 			var index = indexToTest.ToString();
 			var nextIndex = (indexToTest + 1).ToString();
@@ -55,9 +53,8 @@ public async Task CarouselViewGoToNextCurrentItem()
 
 		[Test]
 		[Category(UITestCategories.CarouselView)]
-		public async Task CarouselViewGoToPreviousCurrentItem()
+		public void CarouselViewGoToPreviousCurrentItem()
 		{
-			await Task.Delay(2000);
 			int indexToTest = 3;
 			var index = indexToTest.ToString();
 			var previousIndex = (indexToTest - 1).ToString();
@@ -72,13 +69,13 @@ public async Task CarouselViewGoToPreviousCurrentItem()
 			CheckLabelValue("lblSelected", previousIndex);
 		}
 
-		// Catalyst doesn't support orientation changes
+  // Catalyst doesn't support orientation changes
 #if !MACCATALYST
 		[Test]
 		[Category(UITestCategories.CarouselView)]
-		public async Task CarouselViewKeepPositionChangingOrientation()
+		public void CarouselViewKeepPositionChangingOrientation()
 		{
-			await Task.Delay(2000);
+
 			int indexToTest = 3;
 			var index = indexToTest.ToString();
 
@@ -87,9 +84,11 @@ public async Task CarouselViewKeepPositionChangingOrientation()
 			App.WaitForElement($"CarouselItem{index}");
 
 			App.SetOrientationLandscape();
+			App.WaitForElement($"CarouselItem{index}");
 			App.SetOrientationPortrait();
+			App.WaitForElement($"CarouselItem{index}");
+
 
-			await Task.Delay(3000);
 
 			CheckLabelValue("lblPosition", index);
 			CheckLabelValue("lblCurrentItem", index);
@@ -101,38 +100,38 @@ public async Task CarouselViewKeepPositionChangingOrientation()
 		[Category(UITestCategories.CarouselView)]
 		public void NavigateBackWhenLooped()
 		{
-            int index = 3;
-
-            for (int i = 0; i < 10; i++)
-            {
-                if (index < 0)
-                {
-                    index = 4;
-                }
-                
-                App.WaitForElement($"CarouselItem{index}");
-                App.ScrollLeft("TheCarouselView");
-                index--;
-            }
+			int index = 3;
+
+			for (int i = 0; i < 10; i++)
+			{
+				if (index < 0)
+				{
+					index = 4;
+				}
+
+				App.WaitForElement($"CarouselItem{index}");
+				App.ScrollLeft("TheCarouselView");
+				index--;
+			}
 		}
 
 		[Test]
 		[Category(UITestCategories.CarouselView)]
 		public void NavigateForwardWhenLooped()
 		{
-            int index = 3;
-
-            for (int i = 0; i < 10; i++)
-            {
-                if (index > 4)
-                {
-                    index = 0;
-                }
-                
-                App.WaitForElement($"CarouselItem{index}");
-                App.ScrollRight("TheCarouselView");
-                index++;
-            }
+			int index = 3;
+
+			for (int i = 0; i < 10; i++)
+			{
+				if (index > 4)
+				{
+					index = 0;
+				}
+
+				App.WaitForElement($"CarouselItem{index}");
+				App.ScrollRight("TheCarouselView");
+				index++;
+			}
 		}
 #endif
 
@@ -143,4 +142,4 @@ void CheckLabelValue(string labelAutomationId, string value)
 		}
 	}
 }
-#endif
+#endif

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19152.cs

@@ -19,6 +19,7 @@ public void EntryClearButtonColorShouldMatchTextColor()
 			App.WaitForElement("entry");
 			App.Tap("button");
 #if ANDROID // Skip keyboard on Android to address CI flakiness, Keyboard is not needed validation.
+            Thread.Sleep(500); // Wait for the keyboard to appear
 			if (App.IsKeyboardShown())
 				App.DismissKeyboard();
 #endif

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24574.cs

@@ -25,6 +25,19 @@ public void TapThenDoubleTap()
 			App.WaitForElement("Single");
 
 			App.DoubleTap("TapLabel");
+
+#if ANDROID
+   // In CI Double tap does not effective sometimes so retry once before failing to resolve the flakiness.
+            try
+            {
+                App.WaitForElement("Double");
+            }
+            catch(TimeoutException)
+            {
+                App.WaitForElement("Single");
+                App.DoubleTap("TapLabel");
+            }
+#endif
 			App.WaitForElement("Double");
 		}
 	}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/TimePickerUITest.cs

@@ -1,4 +1,5 @@
-#if TEST_FAILS_ON_CATALYST // TimePicker not opens the dialog, issue: https://github.com/dotnet/maui/issues/10827 
+#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS // TimePicker not opens the dialog, issue: https://github.com/dotnet/maui/issues/10827 
+// Picker popup layout is inconsistent on IOS , issue: https://github.com/dotnet/maui/issues/27898
 using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue1614.cs

@@ -1,4 +1,5 @@
-#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms Android and iOS.
+#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_ANDROID //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms Android and iOS.
+// Cancel button is not displayed after orientation changes on Android issue: https://github.com/dotnet/maui/issues/27900
 using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;