Skip to content

[Android] Properly Resolve File Paths in FilePicker When MANAGE_EXTERNAL_STORAGE is Granted #27975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfversluis merged 2 commits into from
Feb 24, 2025
Merged

[Android] Properly Resolve File Paths in FilePicker When MANAGE_EXTERNAL_STORAGE is Granted #27975

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17bb269
fix
bhavanesh2001 Feb 22, 2025
9a44ab8
Removed CA1416 warning suppression
bhavanesh2001 Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Essentials/src/FilePicker/FilePicker.android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,19 @@ void OnResult(Intent intent)
// The uri returned is only temporary and only lives as long as the Activity that requested it,
// so this means that it will always be cleaned up by the time we need it because we are using
// an intermediate activity.
bool requireExtendedAccess = !(OperatingSystem.IsAndroidVersionAtLeast(30) && Android.OS.Environment.IsExternalStorageManager);

if (intent.ClipData == null)
{
var path = FileSystemUtils.EnsurePhysicalPath(intent.Data);
var path = FileSystemUtils.EnsurePhysicalPath(intent.Data,requireExtendedAccess);
resultList.Add(new FileResult(path));
}
else
{
for (var i = 0; i < intent.ClipData.ItemCount; i++)
{
var uri = intent.ClipData.GetItemAt(i).Uri;
var path = FileSystemUtils.EnsurePhysicalPath(uri);
var path = FileSystemUtils.EnsurePhysicalPath(uri,requireExtendedAccess);
resultList.Add(new FileResult(path));
}
}
Expand Down
Loading