[Android] Fix: Prevent duplicate Completed event when setting ReturnType in Entry#28018
Merged
PureWeen merged 3 commits intodotnet:mainfrom Mar 18, 2025
Merged
[Android] Fix: Prevent duplicate Completed event when setting ReturnType in Entry#28018PureWeen merged 3 commits intodotnet:mainfrom
PureWeen merged 3 commits intodotnet:mainfrom
Conversation
Member
|
Awesome stuff @bhavanesh2001! Can we add a test for this? |
Contributor
Author
|
@jfversluis I added a test. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
previously approved these changes
Feb 25, 2025
Contributor
Author
Contributor
Author
|
It seems like the keyboard should close when In the case of I will include a commit for this change. @PureWeen thoughts? |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
Contributor
Author
|
/rebase |
3d91062 to
cd7ad28
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description of Change
This change fixes an issue where the
Completedevent inEntrytriggers twice on Android when settingReturnType.Root Cause
ReturnType, Android internally updates the ImeOptions, which can cause multiple events to be fired.ImeAction.Done,ImeAction.Search, etc.) and physical keyboard Enter presses were not consistently handled.Completedevent is invoked once by the soft keyboard action (ImeAction) and again by the physical Enter key press (KeyEventActions.Up).Fix Implementation
KeyEventActions.Upfrom firing unnecessarily if the event was already handled by the soft keyboard.Issues Fixed
Fixes #27992