[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 4 by TamilarasanSF4853 · Pull Request #28105 · dotnet/maui

TamilarasanSF4853 · 2025-02-28T12:44:07Z

Description of Change

Migration of Compatibility.Core platform-specific unit tests to device tests. Here the migrated cases which ensuring that the Opacity consistency of different elements matches their native counterparts. We are going to migrate tests in blocks in different PRs. This is the 4st group.

There are unit tests under:

src\Compatibility\Core\tests\Android
src\Compatibility\Core\tests\iOS
src\Compatibility\Core\tests\WinUI

That are not running right now. these cases from Xamarin.Forms where they could run as unit tests, but now with .NET MAUI this is not possible. So here I migrated the following cases in device tests.

This pull request introduces a series of changes across multiple test files to add functionality for verifying the opacity property of various UI elements. The most significant changes include the addition of methods to retrieve the platform-specific opacity values and new test cases to validate the opacity property consistency between the .NET MAUI controls and their native counterparts.

Additions for Opacity Verification:

src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Android.cs: Added GetPlatformOpacity method to retrieve the opacity value for BoxView on Android.
src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Windows.cs: Added GetPlatformOpacity method to retrieve the opacity value for BoxView on Windows.
src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.cs: Added a new test VerifyBoxViewOpacityProperty to check the opacity property of BoxView.

Similar Additions for Other Elements:

src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.Android.cs: Added GetPlatformOpacity method for Button on Android.
src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.Windows.cs: Added GetPlatformOpacity method for Button on Windows.
src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.cs: Added VerifyButtonOpacityProperty test for Button.
src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs: Added GetPlatformOpacity method for CheckBox on Android.
src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Windows.cs: Added GetPlatformOpacity method for CheckBox on Windows.
src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.cs: Added VerifyCheckBoxOpacityProperty test for CheckBox.
src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs: Added GetPlatformOpacity method for Editor on Android.
src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Windows.cs: Added GetPlatformOpacity method for Editor on Windows.
src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.cs: Added VerifyEditorOpacityProperty test for Editor.
src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Android.cs: Added GetPlatformOpacity method for Entry on Android.
src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Windows.cs: Added GetPlatformOpacity method for Entry on Windows.
src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.cs: Added VerifyEntryOpacityProperty test for Entry.
src/Controls/tests/DeviceTests/Elements/Image/ImageTests.Android.cs: Added GetPlatformOpacity method for Image on Android.

Issues Fixed

Fixes #27303

Copilot

PR Overview

This PR migrates several platform-specific unit tests for verifying the opacity consistency of various UI elements from Xamarin.Forms to .NET MAUI device tests. Key changes include:

Addition of a GetPlatformOpacity method in each platform-specific test file (Android, iOS, Windows) for different controls.
Introduction of new tests for BoxView, CheckBox, Button, Entry, Editor, and Image to validate that the native opacity matches the control’s Opacity property.
Updates across multiple test files to ensure the migrated opacity verification cases run on device tests.

Reviewed Changes

File	Description
BoxViewTests.cs	Added VerifyBoxViewOpacityProperty test for BoxView.
CheckBoxTests.cs	Added VerifyCheckBoxOpacityProperty test for CheckBox.
ButtonTests.cs	Added VerifyButtonOpacityProperty test for Button.
EntryTests.cs	Added VerifyEntryOpacityProperty test for Entry.
EditorTests.cs	Added VerifyEditorOpacityProperty test for Editor.
CheckBoxTests.iOS.cs	Added GetPlatformOpacity method for CheckBox on iOS.
CheckBoxTests.Android.cs	Added GetPlatformOpacity method for CheckBox on Android.
CheckBoxTests.Windows.cs	Added GetPlatformOpacity method for CheckBox on Windows.
ButtonTests.Windows.cs	Added GetPlatformOpacity method for Button on Windows.
EditorTests.Windows.cs	Added GetPlatformOpacity method for Editor on Windows.
BoxViewTests.Windows.cs	Added GetPlatformOpacity method for BoxView on Windows.
EntryTests.Windows.cs	Added GetPlatformOpacity method for Entry on Windows.
BoxViewTests.Android.cs	Added GetPlatformOpacity method for BoxView on Android.
ImageTests.Android.cs	Added GetPlatformOpacity and GetPlatformImage methods for Image on Android.
ButtonTests.Android.cs	Added GetPlatformOpacity method for Button on Android.
EditorTests.iOS.cs	Added GetPlatformOpacity method for Editor on iOS.
EntryTests.iOS.cs	Added GetPlatformOpacity method for Entry on iOS.
EntryTests.Android.cs	Added GetPlatformOpacity method for Entry on Android.
EditorTests.Android.cs	Added GetPlatformOpacity method for Editor on Android.

Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs:17

The parameter name 'CheckBoxHandler' is capitalized; consider changing it to 'checkBoxHandler' for consistency with standard naming conventions.

Task<float> GetPlatformOpacity(CheckBoxHandler CheckBoxHandler)

src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.cs

src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.cs

jsuarezruiz · 2025-03-03T06:43:31Z

/azp run

azure-pipelines · 2025-03-03T06:43:51Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

The GetPlatformOpacity method is pending in the ButtonTests.iOS.cs class.

/Users/builder/azdo/_work/1/s/src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.cs(87,36): error CS0103: The name 'GetPlatformOpacity' does not exist in the current context [/Users/builder/azdo/_work/1/s/src/Controls/tests/DeviceTests/Controls.DeviceTests.csproj::TargetFramework=net9.0-ios]
    1 Error(s)

TamilarasanSF4853 · 2025-03-03T12:16:25Z

The GetPlatformOpacity method is pending in the ButtonTests.iOS.cs class.

/Users/builder/azdo/_work/1/s/src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.cs(87,36): error CS0103: The name 'GetPlatformOpacity' does not exist in the current context [/Users/builder/azdo/_work/1/s/src/Controls/tests/DeviceTests/Controls.DeviceTests.csproj::TargetFramework=net9.0-ios]
    1 Error(s)

@jsuarezruiz Resolved the mentioned issue and committed the changes, can you please review and trigger the CI again.

jsuarezruiz · 2025-03-03T16:16:35Z

/azp run

azure-pipelines · 2025-03-03T16:16:58Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-04T12:12:31Z

/rebase

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jsuarezruiz · 2025-03-04T12:19:30Z

/azp run

azure-pipelines · 2025-03-04T12:19:52Z

Azure Pipelines successfully started running 3 pipeline(s).

…s into device tests - 4 (dotnet#28105) * Enabled the Opacity property * code changes * code change * Enabled the Opacity property * code changes * code modifications * changes * Update src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * ios changes * modified codes --------- Co-authored-by: nivetha-nagalingam <nivetha.nagalingam@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…s into device tests - 4 (#28105) * Enabled the Opacity property * code changes * code change * Enabled the Opacity property * code changes * code modifications * changes * Update src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * ios changes * modified codes --------- Co-authored-by: nivetha-nagalingam <nivetha.nagalingam@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Feb 28, 2025

ghost added the area-testing Unit tests, device tests label Feb 28, 2025

TamilarasanSF4853 marked this pull request as ready for review February 28, 2025 12:51

Copilot AI review requested due to automatic review settings February 28, 2025 12:51

TamilarasanSF4853 requested a review from a team as a code owner February 28, 2025 12:51

TamilarasanSF4853 requested review from PureWeen and mattleibow February 28, 2025 12:51

Copilot AI reviewed Feb 28, 2025

View reviewed changes

src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.cs Outdated Show resolved Hide resolved

src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.cs Outdated Show resolved Hide resolved

jsuarezruiz suggested changes Mar 3, 2025

View reviewed changes

nivetha-nagalingam and others added 11 commits March 4, 2025 12:13

Enabled the Opacity property

8319242

code changes

ac18b08

code change

63d8aa3

Enabled the Opacity property

9f991ec

code changes

69203a6

code modifications

5caae84

changes

178e3fe

Update src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.cs

aff7218

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.cs

3124038

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ios changes

7db1963

modified codes

63718ab

jsuarezruiz approved these changes Mar 5, 2025

View reviewed changes

PureWeen merged commit ef9516c into dotnet:main Mar 6, 2025
123 checks passed

github-actions bot locked and limited conversation to collaborators Apr 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 4#28105

[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 4#28105
PureWeen merged 11 commits intomainfrom
unknown repository

TamilarasanSF4853 commented Feb 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

jsuarezruiz commented Mar 3, 2025

Uh oh!

azure-pipelines bot commented Mar 3, 2025

Uh oh!

jsuarezruiz left a comment

Uh oh!

TamilarasanSF4853 commented Mar 3, 2025

Uh oh!

jsuarezruiz commented Mar 3, 2025

Uh oh!

azure-pipelines bot commented Mar 3, 2025

Uh oh!

jsuarezruiz commented Mar 4, 2025

Uh oh!

jsuarezruiz commented Mar 4, 2025

Uh oh!

azure-pipelines bot commented Mar 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

TamilarasanSF4853 commented Feb 28, 2025

Description of Change

Additions for Opacity Verification:

Similar Additions for Other Elements:

Issues Fixed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

PR Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

jsuarezruiz commented Mar 3, 2025

Uh oh!

azure-pipelines bot commented Mar 3, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

TamilarasanSF4853 commented Mar 3, 2025

Uh oh!

jsuarezruiz commented Mar 3, 2025

Uh oh!

azure-pipelines bot commented Mar 3, 2025

Uh oh!

jsuarezruiz commented Mar 4, 2025

Uh oh!

jsuarezruiz commented Mar 4, 2025

Uh oh!

azure-pipelines bot commented Mar 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants