[Testing] Allow to use Theme changes actions on Catalyst#28181
Merged
jfversluis merged 1 commit intomainfrom Mar 28, 2025
Merged
[Testing] Allow to use Theme changes actions on Catalyst#28181jfversluis merged 1 commit intomainfrom
jfversluis merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
A concise update to allow theme change actions on Catalyst by removing the unsupported exception for AppiumCatalystApp instances.
- Removed exception throw in SetLightTheme for Catalyst apps.
- Removed exception throw in SetDarkTheme for Catalyst apps.
Reviewed Changes
| File | Description |
|---|---|
| src/TestUtils/src/UITest.Appium/HelperExtensions.cs | Removed unsupported exception checks to allow theme change actions on Catalyst. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/TestUtils/src/UITest.Appium/HelperExtensions.cs:1643
- The removal of the AppiumCatalystApp check in SetLightTheme implies that theme changes are now supported on Catalyst. Please ensure there are corresponding test cases in TestCases.HostApp and TestCases.Shared.Tests that validate this behavior.
if (app is AppiumCatalystApp)
src/TestUtils/src/UITest.Appium/HelperExtensions.cs:1652
- The removal of the AppiumCatalystApp check in SetDarkTheme now enables theme changes on Catalyst. Please ensure that test cases exist in TestCases.HostApp and TestCases.Shared.Tests to cover this new behavior.
if (app is AppiumCatalystApp)
jfversluis
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow to use Theme changes actions on Catalyst. After include:
maui/src/TestUtils/src/UITest.Appium/Actions/AppiumCatalystThemeChangeAction.cs
Line 5 in 09bca41