-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed content update issue when changing the ControlTemplate at runtime for a ContentPage #28216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
src/Controls/tests/TestCases.HostApp/Issues/Issue15649.xaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
| x:Class="Controls.TestCases.HostApp.Issues.Issue15649" | ||
| xmlns:local="clr-namespace:Controls.TestCases.HostApp.Issues" | ||
| x:Name="HomePage" | ||
| Title="Issue15649"> | ||
| <ContentPage.Resources> | ||
| <ResourceDictionary> | ||
| <ControlTemplate x:Key="Page1"> | ||
| <StackLayout BackgroundColor="Red"> | ||
| <Button Text="Change Value" | ||
| AutomationId="Button" | ||
| Clicked="Button_Clicked"/> | ||
| <Label Text="First Page" | ||
| AutomationId="Page1Label" | ||
| HorizontalOptions="Center" | ||
| VerticalOptions="Center"></Label> | ||
|
|
||
| </StackLayout> | ||
| </ControlTemplate> | ||
| <ControlTemplate x:Key="Page2"> | ||
| <StackLayout BackgroundColor="Blue"> | ||
| <Label Text="Second Page" | ||
| AutomationId="Page2Label" | ||
| HorizontalOptions="Center" | ||
| VerticalOptions="Center"></Label> | ||
| </StackLayout> | ||
|
|
||
| </ControlTemplate> | ||
| </ResourceDictionary> | ||
|
|
||
| </ContentPage.Resources> | ||
| <ContentPage.Triggers> | ||
| <DataTrigger TargetType="ContentPage" | ||
| Binding="{Binding PositionSelected, Source={x:Reference HomePage},x:DataType=local:Issue15649}" | ||
| Value="1"> | ||
| <Setter Property="ControlTemplate" | ||
| Value="{DynamicResource Page1}"/> | ||
| </DataTrigger> | ||
| <DataTrigger TargetType="ContentPage" | ||
| Binding="{Binding PositionSelected, Source={x:Reference HomePage},x:DataType=local:Issue15649}" | ||
| Value="2"> | ||
| <Setter Property="ControlTemplate" | ||
| Value="{DynamicResource Page2}"/> | ||
| </DataTrigger> | ||
| </ContentPage.Triggers> | ||
| </ContentPage> |
32 changes: 32 additions & 0 deletions
32
src/Controls/tests/TestCases.HostApp/Issues/Issue15649.xaml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| namespace Controls.TestCases.HostApp.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 15649, "Updating a ControlTemplate at runtime for a Content Page is not working.", PlatformAffected.All)] | ||
| public partial class Issue15649 : ContentPage | ||
| { | ||
| public int _positionSelected = 1; | ||
|
|
||
| public int PositionSelected | ||
| { | ||
| set | ||
| { | ||
| if (_positionSelected != value) | ||
| { | ||
| _positionSelected = value; | ||
|
|
||
| OnPropertyChanged(); | ||
| } | ||
| } | ||
| get => _positionSelected; | ||
| } | ||
|
|
||
| public Issue15649() | ||
| { | ||
| InitializeComponent(); | ||
| this.BindingContext = this; | ||
| } | ||
| private void Button_Clicked(object sender, EventArgs e) | ||
| { | ||
| PositionSelected = 2; | ||
| } | ||
|
|
||
| } |
19 changes: 19 additions & 0 deletions
19
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue15649.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue15649(TestDevice testDevice) : _IssuesUITest(testDevice) | ||
| { | ||
| public override string Issue => "Updating a ControlTemplate at runtime for a Content Page is not working."; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Page)] | ||
| public void DynamicallyUpdatingContentPage() | ||
| { | ||
| App.WaitForElement("Page1Label"); | ||
| App.Tap("Button"); | ||
| App.WaitForElement("Page2Label"); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.