-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix for Shell does not always raise Navigating event on Windows #28315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 113 additions & 0 deletions
113
src/Controls/tests/TestCases.HostApp/Issues/Issue12500.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| using System.ComponentModel; | ||
| using Maui.Controls.Sample.Issues; | ||
| using Microsoft.Maui; | ||
| using Microsoft.Maui.Controls; | ||
|
|
||
| namespace Controls.TestCases.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 12500, "Shell does not always raise Navigating event on Windows", PlatformAffected.UWP)] | ||
| public class Issue12500 : Shell | ||
| { | ||
| private NavigationViewModel _viewModel; | ||
| public Issue12500() | ||
| { | ||
| this.FlyoutBehavior = FlyoutBehavior.Disabled; | ||
|
|
||
| _viewModel = new NavigationViewModel(); | ||
|
|
||
| // Create TabBar | ||
| var tabBar = new TabBar(); | ||
|
|
||
| // Add ShellContent for MainPage | ||
| tabBar.Items.Add(new ShellContent | ||
| { | ||
| Title = "Hello, World!", | ||
| Route = "MainPage", | ||
| ContentTemplate = new DataTemplate(() => new Issue12500Main { BindingContext = _viewModel }) | ||
| }); | ||
| // Add ShellContent for EventsPage | ||
| tabBar.Items.Add(new ShellContent | ||
| { | ||
| Title = "Events", | ||
| Route = "EventPage", | ||
| ContentTemplate = new DataTemplate(() => new Issue12500EventPage { BindingContext = _viewModel }) | ||
| }); | ||
|
|
||
| // Add TabBar to Shell | ||
| this.Items.Add(tabBar); | ||
| } | ||
| protected override void OnNavigating(ShellNavigatingEventArgs args) | ||
| { | ||
| base.OnNavigating(args); | ||
| string targetPageRoute = args.Target.Location.ToString(); | ||
|
|
||
| // Update ViewModel with new navigation text | ||
| _viewModel.LabelText = $"Navigating to {targetPageRoute}"; | ||
|
|
||
| } | ||
| } | ||
| public class Issue12500EventPage : ContentPage | ||
| { | ||
| public Issue12500EventPage() | ||
| { | ||
| var label = new Label | ||
| { | ||
| AutomationId = "Issue12500EventPage", | ||
| FontSize = 24, | ||
| HorizontalOptions = LayoutOptions.Center, | ||
| VerticalOptions = LayoutOptions.Center | ||
| }; | ||
| label.SetBinding(Label.TextProperty, nameof(NavigationViewModel.LabelText)); // Bind to ViewModel | ||
|
|
||
| Content = new VerticalStackLayout | ||
| { | ||
| Children = { label } | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| public class Issue12500Main : ContentPage | ||
| { | ||
| public Issue12500Main() | ||
| { | ||
| var label = new Label | ||
| { | ||
| AutomationId = "Issue12500MainPage", | ||
| FontSize = 24, | ||
| HorizontalOptions = LayoutOptions.Center, | ||
| VerticalOptions = LayoutOptions.Center | ||
| }; | ||
| label.SetBinding(Label.TextProperty, nameof(NavigationViewModel.LabelText)); // Bind to ViewModel | ||
|
|
||
| Content = new VerticalStackLayout | ||
| { | ||
| Children = { label } | ||
| }; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| public class NavigationViewModel : INotifyPropertyChanged | ||
| { | ||
| private string _labelText; | ||
|
|
||
| public string LabelText | ||
| { | ||
| get => _labelText; | ||
| set | ||
| { | ||
| if (_labelText != value) | ||
| { | ||
| _labelText = value; | ||
| OnPropertyChanged(nameof(LabelText)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public event PropertyChangedEventHandler PropertyChanged; | ||
|
|
||
| protected virtual void OnPropertyChanged(string propertyName) | ||
| { | ||
| PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName)); | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue12500.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue12500 : _IssuesUITest | ||
| { | ||
| public override string Issue => "Shell does not always raise Navigating event on Windows"; | ||
|
|
||
| public Issue12500(TestDevice device) : base(device) | ||
| { | ||
| } | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Shell)] | ||
| public void ShellNavigatingShouldTrigger() | ||
| { | ||
| App.WaitForElement("Issue12500MainPage"); | ||
| App.WaitForElement("Events"); | ||
| App.Tap("Events"); | ||
| var result = App.WaitForElement("Issue12500EventPage").GetText(); | ||
| Assert.That(result, Is.EqualTo("Navigating to //EventPage")); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anywhere else we can call this so that the user can cancel the navigation?
The point of ProposeSection is to give the user time to cancel the navigation
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PureWeen ,
This issue is commonly observed in tab navigation and has not worked in previous cases. I have attached the relevant non-working scenarios, and a separate issue report (#28539) has been created for further investigation.