Skip to content

[Testing] Mark BlankScreenOnNavigationBack as flaky on Android#28377

Closed
jsuarezruiz wants to merge 1 commit intomainfrom
mark-blankscreenonnavigationnack-flaky-test
Closed

[Testing] Mark BlankScreenOnNavigationBack as flaky on Android#28377
jsuarezruiz wants to merge 1 commit intomainfrom
mark-blankscreenonnavigationnack-flaky-test

Conversation

@jsuarezruiz
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz commented Mar 13, 2025 •
edited
Loading

Description of Change

Avoid to run BlankScreenOnNavigationBack test on Android, marked as flaky. Created an issue to re-enable it: #28376

@jsuarezruiz jsuarezruiz added platform/android area-testing Unit tests, device tests labels Mar 13, 2025
Copilot AI review requested due to automatic review settings March 13, 2025 12:49
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner March 13, 2025 12:49
Copilot AI reviewed Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR marks the BlankScreenOnNavigationBack test as flaky on Android builds to avoid its execution, as noted in issue #28376.

  • Wrapped the test with a preprocessor directive to conditionally compile it based on the TEST_FAILS_ON_ANDROID flag.

PureWeen
PureWeen requested changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still flakey?

SF did a PR here
#28269

And it looks green since then
https://dev.azure.com/devdiv/DevDiv/_test/analytics?definitionId=17939&contextType=build
https://devdiv.visualstudio.com/DevDiv/_test/analytics?definitionId=17939&contextType=build

@jsuarezruiz
Copy link
Copy Markdown
Contributor Author

jsuarezruiz commented Mar 13, 2025

Is this still flakey?

SF did a PR here #28269

And it looks green since then https://dev.azure.com/devdiv/DevDiv/_test/analytics?definitionId=17939&contextType=build https://devdiv.visualstudio.com/DevDiv/_test/analytics?definitionId=17939&contextType=build

Failed 3h ago here https://dev.azure.com/xamarin/public/_build/results?buildId=137757&view=ms.vss-test-web.build-test-results-tab&runId=3895797&resultId=100005&paneView=attachments

@jsuarezruiz jsuarezruiz requested a review from PureWeen March 14, 2025 11:50
@bhavanesh2001
Copy link
Copy Markdown
Contributor

bhavanesh2001 commented Mar 15, 2025

#28423

@PureWeen
Copy link
Copy Markdown
Member

PureWeen commented Mar 18, 2025

#28423

@PureWeen PureWeen closed this Mar 18, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis was automatically assigned from dotnet/dotnet-maui-reviewers

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow was automatically assigned from dotnet/dotnet-maui-reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees

No one assigned

Labels

area-testing Unit tests, device tests platform/android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsuarezruiz @bhavanesh2001 @PureWeen