System.MissingMethodException in PropertyPropagationExtensions fix#28456
System.MissingMethodException in PropertyPropagationExtensions fix#28456PureWeen merged 3 commits intodotnet:inflight/candidatefrom
Conversation
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| PropagatePropertyChanged(propertyName, element, children.OfType<IVisualTreeElement>().ToList()); | ||
| } | ||
|
|
||
| internal static void PropagatePropertyChanged(string propertyName, Element element, IReadOnlyList<IVisualTreeElement> children) |
There was a problem hiding this comment.
Can we remove internal from this one?
There was a problem hiding this comment.
removing the internal would force this to be merged on .net 10, no?
There was a problem hiding this comment.
yeah, this will have to go into net10.
But, is there a reason for this to be IReadOnlyList instead of IEnumerable <IVisualTreeElement>? The result is the same as we are just calling ToArray
There was a problem hiding this comment.
I see all the other overloads take Element, so why does this need to be IVisualTreeElement?
|
I need the ifx fast we have issues with our app. |
github-project-automation
bot
moved this from Changes Requested
to Done
in MAUI SDK Ongoing
|
/backport to inflight/current |
|
Started backporting to inflight/current: https://github.com/dotnet/maui/actions/runs/14024228947 |
|
/backport to release/9.0.1xx-sr5 |
|
Started backporting to release/9.0.1xx-sr5: https://github.com/dotnet/maui/actions/runs/14024232238 |
|
When is this available? |
…28456) * Update PropertyPropagationExtensions.cs * Update PropertyPropagationExtensions.cs * Update PropertyPropagationExtensions.cs
…28456) * Update PropertyPropagationExtensions.cs * Update PropertyPropagationExtensions.cs * Update PropertyPropagationExtensions.cs
6 participants
Description of Change
I've added an overload to PropagatePropertyChanged to avoid potential breaks for callers such as the MCT and to maintain backward compatibility, since the original method was internal.
Issues Fixed
Fixes #28450