Skip to content

[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView#28623

Merged
rmarinho merged 3 commits intodotnet:inflight/currentfrom
Ahamed-Ali:fix-28530
Mar 30, 2025
Merged

[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView#28623
rmarinho merged 3 commits intodotnet:inflight/currentfrom
Ahamed-Ali:fix-28530

Conversation

@Ahamed-Ali
Copy link
Copy Markdown
Contributor

@Ahamed-Ali Ahamed-Ali commented Mar 26, 2025 •
edited
Loading

Root Cause of the issue

  • The default normal press and dragging for reordering CollectionView items occur on Mac. There is no CanMixGroups logic for a normal press, as it is already handled by the longPressGestureRecognizer. Therefore, the issue occurs due to interference between the normal press drag and long press gestures.

Description of Change

  • Restrict normal press and dragging on items on Mac, ensuring that only long press gestures are used, as they already handle CanMixGroups properly.

Issues Fixed

Fixes #28530

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
WithoutfixforCanMixGrouFalse.mov
WithFixforCanMixGroupFalse.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 26, 2025
@vishnumenon2684 vishnumenon2684 added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Mar 26, 2025
@jfversluis jfversluis added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Mar 26, 2025
@jsuarezruiz jsuarezruiz added the platform/macos macOS / Mac Catalyst label Mar 26, 2025
jsuarezruiz
jsuarezruiz reviewed Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I tried adding a test case using App.DragAndDrop, but it was not effective, as the test did not fail even without the fix. Therefore, we can proceed with a manual test instead."

Can you share more details? Using App.DragAndDrop and with VerifyScreenshot could be possible to verify it?

@Ahamed-Ali
Copy link
Copy Markdown
Contributor Author

Ahamed-Ali commented Mar 26, 2025

"I tried adding a test case using App.DragAndDrop, but it was not effective, as the test did not fail even without the fix. Therefore, we can proceed with a manual test instead."

Can you share more details? Using App.DragAndDrop and with VerifyScreenshot could be possible to verify it?

I have included the test case with VerifyScreenshot. @jsuarezruiz

@Ahamed-Ali Ahamed-Ali marked this pull request as ready for review March 26, 2025 14:39
@Ahamed-Ali Ahamed-Ali requested a review from a team as a code owner March 26, 2025 14:39
@Ahamed-Ali Ahamed-Ali requested review from PureWeen and rmarinho March 26, 2025 14:39
@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Mar 26, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 26, 2025

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz suggested changes Mar 27, 2025
View reviewed changes
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28530.cs
{
App.WaitForElement("CollectionViewControl");
App.DragAndDrop("Item 2", "Item 3");
VerifyScreenshot();
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshot on some platforms.

For example, Android:
image

Copy link
Copy Markdown
Contributor Author

@Ahamed-Ali Ahamed-Ali Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed the pending images for other platforms. @jsuarezruiz

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28530.cs
{
App.WaitForElement("CollectionViewControl");
App.DragAndDrop("Item 2", "Item 3");
VerifyScreenshot();
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on iOS:
Snapshot different than baseline: ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse.png (1.44% difference)
image

Copy link
Copy Markdown
Contributor Author

@Ahamed-Ali Ahamed-Ali Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resaved the iOS image from CI. Could you please verify it now? @jsuarezruiz

@rmarinho
Copy link
Copy Markdown
Member

rmarinho commented Mar 28, 2025

Can you retarget this to the inflight branch please?

@Ahamed-Ali Ahamed-Ali changed the base branch from main to inflight/current March 28, 2025 11:24
@Ahamed-Ali
Copy link
Copy Markdown
Contributor Author

Ahamed-Ali commented Mar 28, 2025

Can you retarget this to the inflight branch please?

I have retargeted this branch to inflight. @rmarinho

@rmarinho rmarinho merged commit c05aff5 into dotnet:inflight/current Mar 30, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 2, 2025
@Ahamed-Ali @PureWeen
[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reorderin…
c3d7dd2 
…g Between Groups in CollectionView (#28623)

* Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView

* Committed the test case and sample

* Committed the pending snap
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
@Ahamed-Ali @PureWeen
[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reorderin…
5b2afee 
…g Between Groups in CollectionView (#28623)

* Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView

* Committed the test case and sample

* Committed the pending snap
github-actions bot pushed a commit that referenced this pull request Apr 8, 2025
@Ahamed-Ali @PureWeen
[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reorderin…
c31c8fa 
…g Between Groups in CollectionView (#28623)

* Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView

* Committed the test case and sample

* Committed the pending snap
bhavanesh2001 pushed a commit to bhavanesh2001/maui that referenced this pull request Apr 11, 2025
@Ahamed-Ali @bhavanesh2001
[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reorderin…
e26431a 
…g Between Groups in CollectionView (dotnet#28623)

* Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView

* Committed the test case and sample

* Committed the pending snap
PureWeen pushed a commit that referenced this pull request Apr 11, 2025
@Ahamed-Ali @PureWeen
[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reorderin…
35e897f 
…g Between Groups in CollectionView (#28623)

* Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView

* Committed the test case and sample

* Committed the pending snap
github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
@Ahamed-Ali @PureWeen
[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reorderin…
3beccbb 
…g Between Groups in CollectionView (#28623)

* Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView

* Committed the test case and sample

* Committed the pending snap
github-actions bot pushed a commit that referenced this pull request Apr 14, 2025
@Ahamed-Ali @PureWeen
[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reorderin…
86508b2 
…g Between Groups in CollectionView (#28623)

* Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView

* Committed the test case and sample

* Committed the pending snap
github-actions bot pushed a commit that referenced this pull request Apr 15, 2025
@Ahamed-Ali @PureWeen
[Catalyst] Fixed the CanMixGroups Set to False Still Allows Reorderin…
589fd52 
…g Between Groups in CollectionView (#28623)

* Fixed the CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView

* Committed the test case and sample

* Committed the pending snap
@PureWeen PureWeen mentioned this pull request Apr 16, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/macos macOS / Mac Catalyst

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Catalyst] CanMixGroups Set to False Still Allows Reordering Between Groups in CollectionView

6 participants

@Ahamed-Ali @jsuarezruiz @rmarinho @jfversluis @sheiksyedm @vishnumenon2684