Skip to content

[tests] Fix ItemImageSourceShouldBeVisible #28665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 2 commits into from
Mar 27, 2025
Merged

[tests] Fix ItemImageSourceShouldBeVisible #28665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20705df
[tests] Fix ItemImageSourceShouldBeVisible
rmarinho Mar 27, 2025
7c72a3e
Updated test
jsuarezruiz Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added ...rols/tests/TestCases.Mac.Tests/snapshots/mac/ItemImageSourceShouldBeVisible.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18806.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ public Issue18806(TestDevice testDevice) : base(testDevice)
}

public override string Issue => "SwipeItemView won't render FontImageSource on first opening";


#if TEST_FAILS_ON_WINDOWS // Cannot open programatically a SwipeView on Windows.
[Test]
[Category(UITestCategories.SwipeView)]
public void ItemImageSourceShouldBeVisible()
Expand All @@ -21,4 +22,5 @@ public void ItemImageSourceShouldBeVisible()

VerifyScreenshot();
}
#endif
}
5 changes: 5 additions & 0 deletions src/Core/src/Handlers/SwipeView/SwipeViewHandler.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ public static void MapRequestOpen(ISwipeViewHandler handler, ISwipeView swipeVie
{
return;
}

// Note: On Windows, the SwipeView control leverages the underlying SwipeControl from WinUI.
// Unlike other platforms, SwipeControl does not provide a method to programmatically open or reveal its content.
// As a result, programmatic triggering of the swipe functionality is not supported.
// https://learn.microsoft.com/en-us/windows/winui/api/microsoft.ui.xaml.controls.swipecontrol.close?view=winui-2.8
}

public static void MapRequestClose(ISwipeViewHandler handler, ISwipeView swipeView, object? args)
Expand Down
Loading