[Android] Fixed TransformProperties issue when a wrapper view is present by Ahamed-Ali · Pull Request #29228 · dotnet/maui

Ahamed-Ali · 2025-04-28T13:33:32Z

Root Cause of the issue

When a background color is applied to an image, the image is wrapped inside a container view(WrapperView). However, when scaling is applied to the image, the container view (WrapperView) does not account for the scaling, resulting in incorrect rendering.

Description of Change

Apply the scaling to the container view itself when a background color is present, ensuring proper rendering and consistent behavior.

Issues Fixed

Fixes #7432

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Screenshot

Before Issue Fix	After Issue Fix

Copilot

Pull Request Overview

This PR fixes the issue where the scaling transformation was not applied correctly when an image is wrapped inside a container view (WrapperView) on Android. The changes update the transform properties calculation to apply these properties to the WrapperView instead of the inner view and add corresponding UI tests to validate the fix.

Calculate pivot points and other transform properties based on the actual view (either the WrapperView or the original view).
When a WrapperView is detected, apply transform properties on it and reset non-transform values on the inner view.
Added automated tests in both the shared and host app test suites to verify the corrected behavior.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/Core/src/Platform/Android/ViewExtensions.cs	Updated transform properties calculations to account for WrapperView presence
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7432.cs	Added automated UI test for Issue7432
src/Controls/tests/TestCases.HostApp/Issues/Issue7432.cs	Added test UI page for Issue7432 to simulate the issue

Copilot · 2025-04-29T09:20:34Z

src/Core/src/Platform/Android/ViewExtensions.cs

+			var pivotX = (float)(view.AnchorX * transformView.ToPixels(view.Frame.Width));
+			var pivotY = (float)(view.AnchorY * transformView.ToPixels(view.Frame.Height));
+


Ensure that using 'transformView' for calculating pivot accurately reflects the intended pixel conversion when a WrapperView is present. Verify that the view.Frame dimensions used remain valid for the WrapperView's coordinate context.

Suggested change

var pivotX = (float)(view.AnchorX * transformView.ToPixels(view.Frame.Width));

var pivotY = (float)(view.AnchorY * transformView.ToPixels(view.Frame.Height));

float pivotX, pivotY;

if (wrapperView is not null)

{

// Use WrapperView's coordinate context for pixel conversion

pivotX = (float)(view.AnchorX * wrapperView.ToPixels(view.Frame.Width));

pivotY = (float)(view.AnchorY * wrapperView.ToPixels(view.Frame.Height));

}

else

{

// Use platformView's coordinate context for pixel conversion

pivotX = (float)(view.AnchorX * platformView.ToPixels(view.Frame.Width));

pivotY = (float)(view.AnchorY * platformView.ToPixels(view.Frame.Height));

}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7432.cs

jsuarezruiz · 2025-04-30T07:04:46Z

src/Core/src/Platform/Android/ViewExtensions.cs

+				wrapperView.PivotY = pivotY;
+
+				// Apply non-transform properties to the inner view
+				PlatformInterop.Set(platformView,


This is duplicated two times, can create a method with all the transformation properties as parameters?

I have made the changes. please let me know if you have any other concerns. @jsuarezruiz

jsuarezruiz · 2025-05-02T06:03:15Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-02T06:03:26Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-05T07:16:16Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-05T07:16:27Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

The test PropertiesShouldBeCorrectlyApplied, related with transformations, is failing on Android.

Could you review if is related with the changes?

Ahamed-Ali · 2025-05-07T04:56:57Z

The test PropertiesShouldBeCorrectlyApplied, related with transformations, is failing on Android. Could you review if is related with the changes?

I have resaved the correct image. @jsuarezruiz

jsuarezruiz · 2025-05-08T09:43:47Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-08T09:43:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…d by WrapperView container

github-actions · 2025-12-09T09:55:05Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 29228

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 29228"

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Microsoft.Extensions.Logging.Debug](https://dot.net/) ([source](https://github.com/dotnet/dotnet)) | nuget | patch | `10.0.3` -> `10.0.4` | | [Microsoft.Maui.Controls](https://github.com/dotnet/maui) | nuget | patch | `10.0.41` -> `10.0.50` | --- ### Release Notes <details> <summary>dotnet/maui (Microsoft.Maui.Controls)</summary> ### [`v10.0.50`](https://github.com/dotnet/maui/releases/tag/10.0.50) [Compare Source](dotnet/maui@10.0.41...10.0.50) #### What's Changed .NET MAUI 10.0.50 introduces significant improvements across all platforms with focus on quality, performance, and developer experience. This release includes 78 commits with various improvements, bug fixes, and enhancements. #### AI - Enable packing and independent preview versioning for Essentials.AI by [@mattleibow](https://github.com/mattleibow) in dotnet/maui#33976 - Move Essentials.AI preview iteration to eng/Versions.props by [@mattleibow](https://github.com/mattleibow) in dotnet/maui#34025 - \[Feature] Add Microsoft.Maui.Essentials.AI - Apple Intelligence by [@mattleibow](https://github.com/mattleibow) in dotnet/maui#33519 #### Ai Agents - Copilot agent infrastructure, emulator reliability, and try-fix workflow improvements by [@PureWeen](https://github.com/PureWeen) via [@Copilot](https://github.com/Copilot) in dotnet/maui#33937 - Update PR agent models to claude-sonnet-4.6 and gpt-5.3-codex by [@kubaflo](https://github.com/kubaflo) in dotnet/maui#34109 - ci-copilot: set pipeline run title early using build.updatebuildnumber by [@jfversluis](https://github.com/jfversluis) via [@Copilot](https://github.com/Copilot) in dotnet/maui#34156 - Revamp find-reviewable-pr skill: priorities, defaults, and doc fixes by [@PureWeen](https://github.com/PureWeen) in dotnet/maui#34160 - Add correct CI pipeline names to Copilot instructions by [@jfversluis](https://github.com/jfversluis) in dotnet/maui#34255 - Add resilience to UI tests for frozen/unresponsive apps by [@PureWeen](https://github.com/PureWeen) in dotnet/maui#34023 - Copilot CI: Structured phase outputs, autonomous execution, iOS support, and CI pipeline by [@kubaflo](https://github.com/kubaflo) in dotnet/maui#34040 - Agent Workflow Metrics via GitHub Labels by [@kubaflo](https://github.com/kubaflo) in dotnet/maui#33986 #### Animation - \[Android] Fixed TransformProperties issue when a wrapper view is present by [@Ahamed-Ali](https://github.com/Ahamed-Ali) in dotnet/maui#29228 <...

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Apr 28, 2025

Ahamed-Ali marked this pull request as ready for review April 29, 2025 09:19

Copilot AI review requested due to automatic review settings April 29, 2025 09:19

Ahamed-Ali requested a review from a team as a code owner April 29, 2025 09:19

Ahamed-Ali requested review from jsuarezruiz and rmarinho April 29, 2025 09:19

Copilot AI reviewed Apr 29, 2025

View reviewed changes

jsuarezruiz added area-animation Animation, Transitions, Transforms platform/android labels Apr 30, 2025

jsuarezruiz suggested changes Apr 30, 2025

View reviewed changes

jsuarezruiz suggested changes May 6, 2025

View reviewed changes

Ahamed-Ali added 9 commits December 9, 2025 15:06

Fixed the scaling issues with the Image in Android image

314f32b

Fixed transform properties not applying correctly when view is wrappe…

864e57b

…d by WrapperView container

Included the test sample and test case for the issue

50f888c

Added verifyscreenshot

f564a70

Updated the fix with wrapperView Updated only to the transformProperties

e1b2ad6

Added iOS image

619d8b7

Optimized the code

0fecc80

Committed the pending snap of mac and windows

3a95019

Resaved the correct image

200a598

Ahamed-Ali force-pushed the fix-7432 branch from 0327ee5 to 200a598 Compare December 9, 2025 09:54

dependabot bot mentioned this pull request Mar 11, 2026

Bump Microsoft.Maui.Controls from 10.0.41 to 10.0.50 TheCodeTraveler/AsyncAwaitBestPractices#271

Merged

github-actions bot locked and limited conversation to collaborators Mar 23, 2026

		var pivotX = (float)(view.AnchorX * transformView.ToPixels(view.Frame.Width));
		var pivotY = (float)(view.AnchorY * transformView.ToPixels(view.Frame.Height));

-			var pivotX = (float)(view.AnchorX * transformView.ToPixels(view.Frame.Width));
-			var pivotY = (float)(view.AnchorY * transformView.ToPixels(view.Frame.Height));
+			float pivotX, pivotY;
+			if (wrapperView is not null)
+			{
+				// Use WrapperView's coordinate context for pixel conversion
+				pivotX = (float)(view.AnchorX * wrapperView.ToPixels(view.Frame.Width));
+				pivotY = (float)(view.AnchorY * wrapperView.ToPixels(view.Frame.Height));
+			}
+			else
+			{
+				// Use platformView's coordinate context for pixel conversion
+				pivotX = (float)(view.AnchorX * platformView.ToPixels(view.Frame.Width));
+				pivotY = (float)(view.AnchorY * platformView.ToPixels(view.Frame.Height));
+			}

Conversation

Ahamed-Ali commented Apr 28, 2025

Root Cause of the issue

Description of Change

Issues Fixed

Tested the behaviour in the following platforms

Screenshot

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jsuarezruiz Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented May 2, 2025

Uh oh!

azure-pipelines bot commented May 2, 2025

Uh oh!

jsuarezruiz commented May 5, 2025

Uh oh!

azure-pipelines bot commented May 5, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali commented May 7, 2025

Uh oh!

jsuarezruiz commented May 8, 2025

Uh oh!

azure-pipelines bot commented May 8, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants