[tests] Add coreclr test for SF sample#29327
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new CoreCLR test case for the SF sample to address testing improvements mentioned in issue #29320.
- Added a new test case using the parameter "--sample-content" with "UseMonoRuntime=false" in Release configuration.
- A Debug test case for the same scenario is commented out with a note indicating it's not ready yet.
Comments suppressed due to low confidence (1)
src/TestUtils/src/Microsoft.Maui.IntegrationTests/SimpleTemplateTest.cs:18
- Ensure that this new test case is adequately reflected in both TestCases.HostApp and TestCases.Shared.Tests to maintain consistency in automated testing.
[TestCase("maui", DotNetCurrent, "Release", false, "--sample-content", "UseMonoRuntime=false")]
jfversluis
reviewed
May 5, 2025
matouskozak
previously approved these changes
May 5, 2025
Member
Author
|
@jonathanpeppers https://dev.azure.com/xamarin/public/_build/results?buildId=141123&view=ms.vss-test-web.build-test-results-tab&runId=4089349&resultId=100050&paneView=attachments do I need to enable something? or the error is correct ? |
Member
|
@rmarinho you will need to remove all |
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
If you have TreatWarningsAsErrors you will need to pass -p:EnablePreviewFeatures=true:
/Users/builder/azdo/_work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Darwin/36.0.0-preview.4.77/tools/Xamarin.Android.Common.targets(570,3): error XA1040: The CoreCLR runtime on Android is an experimental feature and not yet suitable for production use. File issues at: https://github.com/dotnet/android/issues
eea386d to
d3b79fe
Compare
Member
Author
jonathanpeppers
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Try add a test for #29320
Issues Fixed
Fixes #