[Android] Fixed Button Shadow Color Transparency Not Applied Correctly by NanthiniMahalingam · Pull Request #29371 · dotnet/maui

NanthiniMahalingam · 2025-05-07T10:16:04Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause

The button's shadow rendering does not account for the color's alpha value in android platform.

Description of Change

Handled shadow color transparency and opacity when both color alpha and opacity values are present, ensuring consistent behavior across platforms.
If the color has an alpha value, shadow transparency is applied based on that alpha.
If the Opacity property is set directly, shadow transparency is applied based on the Opacity value.

Validated the behaviour in the following platforms

Android
Windows
iOS
Mac

Issues Fixed

Fixes #29325

Output images

Android

Before	After

jsuarezruiz · 2025-05-08T05:59:52Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-08T06:00:04Z

Azure Pipelines successfully started running 1 pipeline(s).

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29325.cs

jsuarezruiz · 2025-05-08T06:59:33Z

src/Core/src/Platform/Android/WrapperView.cs

-				var shadowOpacity = Shadow.Opacity;
+				var paintColorAlpha = shadowPaint.ToColor().Alpha;
+				// If the color has an alpha value indicating transparency, we can use that; otherwise, we can use the shadow opacity.
+				var shadowOpacity = paintColorAlpha == 1 ? Shadow.Opacity : paintColorAlpha;


What's the behavior in other platforms?

What's the behavior in other platforms?

Hi @jsuarezruiz ,

On other platforms, shadow color (with alpha) and shadow opacity are handled separately. When both a color with alpha and an opacity value are provided, they are combined to produce the final shadow effect.

The refined code section aligns with this behavior by merging both values to ensure consistent and platform-aligned shadow rendering.

jsuarezruiz · 2025-05-12T11:53:02Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-12T11:53:12Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-16T11:44:51Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-16T11:45:04Z

Azure Pipelines successfully started running 1 pipeline(s).

mattleibow

Looking good, but I think may need more tests.

src/Controls/tests/TestCases.HostApp/Issues/Issue29325.cs

jsuarezruiz · 2025-05-30T08:14:25Z

/azp run

azure-pipelines · 2025-05-30T08:14:46Z

Azure Pipelines successfully started running 3 pipeline(s).

#29371) * Fixed the shadow transparent issue on android * Updated the fix. * Added the test case and updated the fix * Added the output images. * Updated the fix. * Updated the comment. * Added the output images for mac and Windows * Updated the test case and added output images. * Added the output images

@Shalini-Ashokan

For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - inflight/candidate Branch ## MAUI Product Fixes * [iOS] Fix SwipeView programmatic open when background color is set by @Shalini-Ashokan in #29765 * [iOS] FormattedText with text color causes stack overflow - fix by @kubaflo in #29874 * [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in #20987 * [iOS] Fix for Flyout title is not broken over multiple lines when you rotate your screen by @BagavathiPerumal in #29171 * [Windows] Fix for Assigning null to the SelectedItem of the CollectionView in the SelectionChanged event does not clear the selection by @SyedAbdulAzeemSF4852 in #29288 * Fix TapCoordinates method in Catalyst by @jsuarezruiz in #29775 * Fixed ItemSpacing on CarouselView resizes items [Android] by @Dhivya-SF4094 in #29796 * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double by @antoine-jonathan in #25393 * ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in #28833 * [Android] Fixed Button Shadow Color Transparency Not Applied Correctly by @NanthiniMahalingam in #29371 * Don't call NSAttributedString with HTML from a background thread by @kubaflo in #26153 * [Windows] Implemented the Resize and Downsize functions in the W2DImage class by @HarishwaranVijayakumar in #29138 * Templated indicator view - improvements by @kubaflo in #25642 * Update Issue25946.xaml by @anandhan-rajagopal in #30025 ## Testing * Fixed Test case failure in PR 26153 - iOS by @kubaflo in #29906 * Fixed Test case failure in PR 25642 - snapshots by @kubaflo in #29881 * [Testing] Feature Matrix UITest Cases for RadioButton by @TamilarasanSF4853 in #29744 * [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource Feature by @LogishaSelvarajSF4525 in #29322 * [Testing] Feature Matrix UITest Cases for Stepper by @nivetha-nagalingam in #29731 * [Testing] Feature Matrix UITest Cases for CheckBox Control by @anandhan-rajagopal in #29739 * Update the comment for the test properties by @mattleibow in #27306 ## Dependency Updates * No changes in this category ## Docs * No changes in this category ## Housekeeping * [create-pull-request] automated change by @github-actions[bot] in #29875 * [create-pull-request] automated change by @github-actions[bot] in #29792 * [create-pull-request] automated change by @github-actions[bot] in #29760 **Full Changelog**: origin/main...origin/inflight/candidate

#29371) * Fixed the shadow transparent issue on android * Updated the fix. * Added the test case and updated the fix * Added the output images. * Updated the fix. * Updated the comment. * Added the output images for mac and Windows * Updated the test case and added output images. * Added the output images

NanthiniMahalingam added 4 commits May 6, 2025 16:24

Fixed the shadow transparent issue on android

56ea05c

Updated the fix.

a5439c2

Added the test case and updated the fix

5395951

Added the output images.

10ab96c

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 7, 2025

NanthiniMahalingam changed the title ~~Fixed Button Shadow Color Transparency Not Applied Correctly~~ Fixed Button Shadow Color Transparency Not Applied Correctly on android platform May 7, 2025

NanthiniMahalingam changed the title ~~Fixed Button Shadow Color Transparency Not Applied Correctly on android platform~~ [Android] Fixed Button Shadow Color Transparency Not Applied Correctly May 7, 2025

Tamilarasan-Paranthaman added the platform/android label May 7, 2025

jsuarezruiz suggested changes May 8, 2025

View reviewed changes

NanthiniMahalingam added 2 commits May 8, 2025 16:44

Updated the fix.

d702917

Updated the comment.

0f3d49d

NanthiniMahalingam marked this pull request as ready for review May 8, 2025 13:21

NanthiniMahalingam requested a review from a team as a code owner May 8, 2025 13:21

NanthiniMahalingam requested review from PureWeen and rmarinho May 8, 2025 13:21

Added the output images for mac and Windows

8c11156

PureWeen added this to the .NET 9 SR8 milestone May 20, 2025

PureWeen added this to MAUI SDK Ongoing May 20, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing May 20, 2025

PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing May 20, 2025

mattleibow requested changes May 23, 2025

View reviewed changes

src/Controls/tests/TestCases.HostApp/Issues/Issue29325.cs Show resolved Hide resolved

github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing May 23, 2025

Updated the test case and added output images.

a17ae82

Added the output images

5443fc4

PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Jun 2, 2025

PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Jun 2, 2025

mattleibow approved these changes Jun 2, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current June 2, 2025 20:06

PureWeen merged commit a37549a into dotnet:inflight/current Jun 2, 2025
1 check passed

github-project-automation bot moved this from Ready To Review to Done in MAUI SDK Ongoing Jun 2, 2025

PureWeen mentioned this pull request Jun 20, 2025

[2025/06/16] Candidate - In Flight Branch #29886

Merged

PureWeen modified the milestones: .NET 9 SR8, .NET 9 SR9 Jun 23, 2025

github-actions bot locked and limited conversation to collaborators Jul 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Fixed Button Shadow Color Transparency Not Applied Correctly#29371

[Android] Fixed Button Shadow Color Transparency Not Applied Correctly#29371
PureWeen merged 9 commits intodotnet:inflight/currentfrom
NanthiniMahalingam:fix-29325

NanthiniMahalingam commented May 7, 2025 •

edited

Loading

Uh oh!

jsuarezruiz commented May 8, 2025

Uh oh!

azure-pipelines bot commented May 8, 2025

Uh oh!

Uh oh!

jsuarezruiz May 8, 2025

Uh oh!

NanthiniMahalingam May 8, 2025

Uh oh!

jsuarezruiz commented May 12, 2025

Uh oh!

azure-pipelines bot commented May 12, 2025

Uh oh!

jsuarezruiz commented May 16, 2025

Uh oh!

azure-pipelines bot commented May 16, 2025

Uh oh!

mattleibow left a comment

Uh oh!

Uh oh!

jsuarezruiz commented May 30, 2025

Uh oh!

azure-pipelines bot commented May 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

NanthiniMahalingam commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause

Description of Change

Issues Fixed

Output images

Uh oh!

jsuarezruiz commented May 8, 2025

Uh oh!

azure-pipelines bot commented May 8, 2025

Uh oh!

Uh oh!

jsuarezruiz May 8, 2025

Choose a reason for hiding this comment

Uh oh!

NanthiniMahalingam May 8, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented May 12, 2025

Uh oh!

azure-pipelines bot commented May 12, 2025

Uh oh!

jsuarezruiz commented May 16, 2025

Uh oh!

azure-pipelines bot commented May 16, 2025

Uh oh!

mattleibow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jsuarezruiz commented May 30, 2025

Uh oh!

azure-pipelines bot commented May 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

NanthiniMahalingam commented May 7, 2025 •

edited

Loading