[Testing] Feature matrix UITest Cases for SwipeView Control by LogishaSelvarajSF4525 · Pull Request #30968 · dotnet/maui

LogishaSelvarajSF4525 · 2025-08-01T07:54:02Z

This PR includes a comprehensive set of UI test cases for the SwipeView control. The tests validate the SwipeView control’s behavior across a wide range of properties and interaction scenarios. This includes verifying SwipeItems for all supported directions—LeftItems, RightItems, TopItems, and BottomItems—to ensure they are correctly displayed and invoked. Event validation covers key swipe lifecycle events such as SwipeStarted, SwipeChanging, SwipeEnded, and SwipeItem.Invoked, confirming their correct firing during user interactions. The tests also assess various SwipeView properties like IsEnabled, IsVisible, BackgroundColor, HeightRequest, and WidthRequest, ensuring they update the control as expected. Additionally, support for programmatic control using OpenRequested and CloseRequested is validated. Finally, the tests confirm consistent swipe gesture handling across all platforms.

SwipeView Control Feature Matrix

Gallery Page Addition

Integrated a new GalleryPageFactory entry for SwipeViewControlPage into CorePageView.cs.
Enables easy navigation to the feature matrix page showcasing SwipeView control functionality within the test app.

Options Page Implementation

Created SwipeViewOptionsPage.xaml to provide a UI for dynamic interaction with SwipeView properties.
The options page includes:
- Configuration for SwipeItem directions and content types (Label, Image, CollectionView).
- Toggle support for visual properties like background, border, visibility, and enabled state.
- Binding support for SwipeItems and swipe events.

Main Page Implementation

Added SwipeViewControlPage.xaml.cs, which includes:
- Initialization of SwipeViewViewModel for dynamic property and event binding.
- Methods to generate content and SwipeItems dynamically based on user selections.
- Handlers for programmatically opening and closing SwipeView via command buttons.
- Wiring up of swipe gesture event tracking for testing behavior during swipes.

Issues Identified

Screen.Recording.2025-07-02.at.3.50.54.PM.mov

jsuarezruiz · 2025-08-01T09:58:59Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-08-01T09:59:11Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR introduces comprehensive UI test cases for the SwipeView control to validate its behavior across different properties and interaction scenarios. The implementation includes a full feature matrix testing framework that covers SwipeItems for all directions, event validation, property testing, and programmatic control support.

Adds extensive UI test coverage for SwipeView control functionality across platforms
Implements a comprehensive feature matrix page with options to test various SwipeView configurations
Creates test infrastructure to validate SwipeItems, events, properties, and programmatic actions

Reviewed Changes

Copilot reviewed 6 out of 77 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
SwipeViewFeatureTests.cs	Comprehensive test suite with 40+ test cases covering SwipeView functionality
SwipeViewViewModel.cs	ViewModel implementing property binding and command handling for SwipeView testing
SwipeViewOptionsPage.xaml.cs	Code-behind for options page providing UI configuration controls
SwipeViewOptionsPage.xaml	XAML layout for test configuration options with radio buttons and controls
SwipeViewControlPage.cs	Main test page implementation with dynamic content generation and event handling
CorePageView.cs	Gallery integration to make SwipeView feature matrix accessible in test app

Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/SwipeViewFeatureTests.cs:254

The test methods are duplicating the navigation to Options page and configuration steps repeatedly. Consider extracting common setup logic into helper methods to reduce code duplication and improve maintainability.

		App.WaitForElement("Options");

Copilot · 2025-08-05T10:01:00Z

+		_viewModel.RequestOpen += dir =>
+	{
+		Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Open(dir));
+	};
+
+		_viewModel.RequestClose += () =>
+		{
+			Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Close());
+		};


The event handlers for RequestOpen and RequestClose are being added every time WireUpOpenCloseHandlers is called, which could lead to memory leaks and multiple event subscriptions. Consider unsubscribing from previous handlers before adding new ones.

Suggested change

_viewModel.RequestOpen += dir =>

{

Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Open(dir));

};

_viewModel.RequestClose += () =>

{

Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Close());

};

// Unsubscribe previous handlers if they exist

if (_requestOpenHandler != null)

_viewModel.RequestOpen -= _requestOpenHandler;

if (_requestCloseHandler != null)

_viewModel.RequestClose -= _requestCloseHandler;

// Create new handlers

_requestOpenHandler = dir =>

{

Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Open(dir));

};

_requestCloseHandler = () =>

{

Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Close());

};

// Subscribe new handlers

_viewModel.RequestOpen += _requestOpenHandler;

_viewModel.RequestClose += _requestCloseHandler;

I have made the changes based on your valid suggestion and committed the latest updates.

Copilot · 2025-08-05T10:01:00Z

+						var swipeItems = CreateSwipeItems(swipeItemType);
+						var swipeView = new SwipeView
+						{
+							Content = itemLabel,
+							LeftItems = swipeItems,
+							RightItems = swipeItems,
+							TopItems = swipeItems,
+							BottomItems = swipeItems,


The same swipeItems collection is being assigned to LeftItems, RightItems, TopItems, and BottomItems. This could cause issues since collections should not be shared between multiple properties. Consider creating separate SwipeItems instances for each direction.

Suggested change

var swipeItems = CreateSwipeItems(swipeItemType);

var swipeView = new SwipeView

{

Content = itemLabel,

LeftItems = swipeItems,

RightItems = swipeItems,

TopItems = swipeItems,

BottomItems = swipeItems,

var leftSwipeItems = CreateSwipeItems(swipeItemType);

var rightSwipeItems = CreateSwipeItems(swipeItemType);

var topSwipeItems = CreateSwipeItems(swipeItemType);

var bottomSwipeItems = CreateSwipeItems(swipeItemType);

var swipeView = new SwipeView

{

Content = itemLabel,

LeftItems = leftSwipeItems,

RightItems = rightSwipeItems,

TopItems = topSwipeItems,

BottomItems = bottomSwipeItems,

I have made the changes based on your valid suggestion and committed the latest updates.

Copilot · 2025-08-05T10:01:00Z

+		var swipeItems = CreateSwipeItems(swipeItemType);
+
+		var swipeView = new SwipeView
+		{
+			Content = contentView,
+			LeftItems = swipeItems,
+			RightItems = swipeItems,
+			TopItems = swipeItems,
+			BottomItems = swipeItems,


Same issue as in the CollectionView template - the same swipeItems collection is being reused for all directions. Each SwipeView direction should have its own SwipeItems instance to prevent potential binding and state conflicts.

Suggested change

var swipeItems = CreateSwipeItems(swipeItemType);

var swipeView = new SwipeView

{

Content = contentView,

LeftItems = swipeItems,

RightItems = swipeItems,

TopItems = swipeItems,

BottomItems = swipeItems,

var leftItems = CreateSwipeItems(swipeItemType);

var rightItems = CreateSwipeItems(swipeItemType);

var topItems = CreateSwipeItems(swipeItemType);

var bottomItems = CreateSwipeItems(swipeItemType);

var swipeView = new SwipeView

{

Content = contentView,

LeftItems = leftItems,

RightItems = rightItems,

TopItems = topItems,

BottomItems = bottomItems,

I have made the changes based on your valid suggestion and committed the latest updates.

jsuarezruiz · 2025-09-02T05:54:05Z

/rebase

jsuarezruiz · 2025-09-02T09:03:48Z

/azp run

azure-pipelines · 2025-09-02T09:04:11Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

The test VerifyImageWithSwipeRevealAndSwipeBehaviorOnInvokedAuto is failing on Mac:

   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2530
   at UITest.Appium.HelperExtensions.WaitForNone(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2554
   at UITest.Appium.HelperExtensions.WaitForNoElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 816
   at Microsoft.Maui.TestCases.Tests.SwipeViewFeatureTests.VerifyImageWithSwipeRevealAndSwipeBehaviorOnInvokedAuto() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/SwipeViewFeatureTests.cs:line 503
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

LogishaSelvarajSF4525 · 2025-09-05T08:12:13Z

The test VerifyImageWithSwipeRevealAndSwipeBehaviorOnInvokedAuto is failing on Mac:

   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2530
   at UITest.Appium.HelperExtensions.WaitForNone(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2554
   at UITest.Appium.HelperExtensions.WaitForNoElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 816
   at Microsoft.Maui.TestCases.Tests.SwipeViewFeatureTests.VerifyImageWithSwipeRevealAndSwipeBehaviorOnInvokedAuto() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/SwipeViewFeatureTests.cs:line 503
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@jsuarezruiz Modified the test to ensure it runs on Mac and committed the code changes.

jsuarezruiz · 2025-09-05T11:41:58Z

/azp run

azure-pipelines · 2025-09-05T11:42:17Z

Azure Pipelines successfully started running 3 pipeline(s).

* added the sample and test class files * added snapshot for iOS and android * added FailsOn attributes * updated * test case modified * changes updated * revert this changes * added snapshot from CI * update copilot suggestion * update test case --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

dotnet-policy-service Bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Aug 1, 2025

ghost added area-testing Unit tests, device tests area-controls-swipeview SwipeView labels Aug 1, 2025

LogishaSelvarajSF4525 marked this pull request as ready for review August 5, 2025 09:59

Copilot AI review requested due to automatic review settings August 5, 2025 09:59

LogishaSelvarajSF4525 requested a review from a team as a code owner August 5, 2025 09:59

LogishaSelvarajSF4525 requested review from StephaneDelcroix and rmarinho August 5, 2025 09:59

Copilot AI reviewed Aug 5, 2025

View reviewed changes

LogishaSelvarajSF4525 added 9 commits September 2, 2025 05:54

added the sample and test class files

e86a3ad

added snapshot for iOS and android

ec4f560

added FailsOn attributes

14327c7

updated

81737f5

test case modified

c9d9f94

changes updated

bcc7dd3

revert this changes

d0dab72

added snapshot from CI

944c706

update copilot suggestion

f652f22

jsuarezruiz suggested changes Sep 4, 2025

View reviewed changes

update test case

08557ff

jsuarezruiz approved these changes Sep 9, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current September 11, 2025 15:47

Merge branch 'inflight/current' into logi-swipeviewfeature

d20f71e

PureWeen merged commit 38aad66 into dotnet:inflight/current Sep 11, 2025

github-actions Bot locked and limited conversation to collaborators Oct 12, 2025

-		_viewModel.RequestOpen += dir =>
-	{
-		Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Open(dir));
-	};
-		_viewModel.RequestClose += () =>
-		{
-			Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Close());
-		};
+		// Unsubscribe previous handlers if they exist
+		if (_requestOpenHandler != null)
+			_viewModel.RequestOpen -= _requestOpenHandler;
+		if (_requestCloseHandler != null)
+			_viewModel.RequestClose -= _requestCloseHandler;
+		// Create new handlers
+		_requestOpenHandler = dir =>
+		{
+			Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Open(dir));
+		};
+		_requestCloseHandler = () =>
+		{
+			Microsoft.Maui.ApplicationModel.MainThread.BeginInvokeOnMainThread(() => swipeView.Close());
+		};
+		// Subscribe new handlers
+		_viewModel.RequestOpen += _requestOpenHandler;
+		_viewModel.RequestClose += _requestCloseHandler;

Conversation

LogishaSelvarajSF4525 commented Aug 1, 2025

SwipeView Control Feature Matrix

Uh oh!

jsuarezruiz commented Aug 1, 2025

Uh oh!

azure-pipelines Bot commented Aug 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

LogishaSelvarajSF4525 Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

LogishaSelvarajSF4525 Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

LogishaSelvarajSF4525 Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Sep 2, 2025

Uh oh!

jsuarezruiz commented Sep 2, 2025

Uh oh!

azure-pipelines Bot commented Sep 2, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

LogishaSelvarajSF4525 commented Sep 5, 2025

Uh oh!

jsuarezruiz commented Sep 5, 2025

Uh oh!

azure-pipelines Bot commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants