Radio Button Null Selection Fix by asi-evin · Pull Request #31175 · dotnet/maui

asi-evin · 2025-08-14T17:13:34Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Allows Radio Button group controller Value to be set to null. This can clear radio button(s) that have been selected.

Issues Fixed

Fixes #19437

asi-evin · 2025-08-14T17:14:44Z

@asi-evin please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@dotnet-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement

@dotnet-policy-service agree

jfversluis · 2025-08-19T09:26:39Z

/azp run

azure-pipelines · 2025-08-19T09:27:02Z

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis

Looks like we have a failing unit test: Microsoft.Maui.Controls.Core.UnitTests.RadioButtonTests.ImpliedGroupDoesNotIncludeExplicitGroups

asi-evin · 2025-08-19T15:17:17Z

I noticed. Some observations:

if I run the unit test by itself, it passes.
if I set a value for radio button 3 like so, it passes:

- Edit: If I change the groupname to "bar", ity passes.

@jfversluis I've been trying to debug, but would appreciate some wisdom if it's available.

asi-evin · 2025-08-19T15:57:15Z

/azp run

azure-pipelines · 2025-08-19T15:57:22Z

Commenter does not have sufficient privileges for PR 31175 in repo dotnet/maui

jfversluis · 2025-08-20T12:23:31Z

/azp run MAUI-public

azure-pipelines · 2025-08-20T12:23:43Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis · 2025-08-21T12:32:34Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-08-21T12:32:47Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis

Unfortunately some failing UI tests still. Unit tests look OK now!

asi-evin · 2025-08-22T04:16:12Z

@jfversluis How do I run these UI tests locally? I can't seem to figure out how to run them.

MartyIX · 2025-08-22T08:30:04Z

@jfversluis How do I run these UI tests locally? I can't seem to figure out how to run them.

https://github.com/dotnet/maui/wiki/UITests#running-from-visual-studio-code-requires-c-dev-kit-with-net-maui-extension-installed

I simply run Controls.TestCases.HostApp in my Visual Studio, type the issue number in the application that pops up, and then the test is run.

asi-evin · 2025-08-22T15:46:18Z

@jfversluis How do I run these UI tests locally? I can't seem to figure out how to run them.

https://github.com/dotnet/maui/wiki/UITests#running-from-visual-studio-code-requires-c-dev-kit-with-net-maui-extension-installed

I simply run Controls.TestCases.HostApp in my Visual Studio, type the issue number in the application that pops up, and then the test is run.

Thank, I was able to somewhat figure it out.

@jfversluis, I have made a change but it feels... hacky... so if it's not appropriate, I'll take some time to think of a different solution.

asi-evin · 2025-09-11T14:41:36Z

@jfversluis I have have used the more conventional way of ensuring the value is "coerced" to itself if set to null. Can the test be run again?

azure-pipelines · 2025-09-12T21:23:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-09-13T10:40:54Z

Azure Pipelines successfully started running 1 pipeline(s).

asi-evin · 2025-09-15T17:03:57Z

@jfversluis Forgive my ignorance here, but it looks like the failures are all simulators that failed to start??? Is that correct??? Or am I missing something and there's something I need to change?

jfversluis · 2025-09-17T08:37:24Z

Thank you for your contribution!

* Added UI test for null selectin bug * Handle when group update changes to no values * Added unit test * new file to file scoped namespace * Ignore child added if layout is null * Piggy backed off of existing UI sample * removing unused using * reverting whitespace * removing unused using * Have RadioButton default to itself for uniqueness * Added comment justifying madness * less hacky way * Less hacky and added unit test --------- Co-authored-by: Evin Ballantyne <EBallantyne@acceleratedsystems.com>

asi-evin requested a review from a team as a code owner August 14, 2025 17:13

asi-evin requested review from StephaneDelcroix and jfversluis August 14, 2025 17:13

dotnet-policy-service Bot added the community ✨ Community Contribution label Aug 14, 2025

MartyIX reviewed Aug 14, 2025

View reviewed changes

Comment thread src/Controls/samples/Controls.Sample/ViewModels/RadioButtonNullSelectionViewModel.cs Outdated

asi-evin changed the title ~~Fix 19437~~ Radio Button Null Selection Fix Aug 15, 2025

jfversluis requested changes Aug 19, 2025

View reviewed changes

asi-evin requested a review from jfversluis August 19, 2025 17:07

jfversluis requested changes Aug 21, 2025

View reviewed changes

asi-evin requested a review from jfversluis August 22, 2025 15:45

jfversluis approved these changes Sep 17, 2025

View reviewed changes

jfversluis changed the base branch from main to inflight/current September 17, 2025 08:22

Added UI test for null selectin bug

c148e29

Evin Ballantyne added 12 commits September 17, 2025 10:36

Handle when group update changes to no values

d65b6f2

Added unit test

bb89c8c

new file to file scoped namespace

c539d79

Ignore child added if layout is null

303192b

Piggy backed off of existing UI sample

49f6d18

removing unused using

96b53ac

reverting whitespace

9690bd7

removing unused using

4020ad1

Have RadioButton default to itself for uniqueness

bf19cbd

Added comment justifying madness

7eb8f87

less hacky way

4e33bd5

Less hacky and added unit test

8adfcdd

jfversluis force-pushed the fix-19437 branch from cdebed7 to 8adfcdd Compare September 17, 2025 08:36

jfversluis merged commit 7e628a3 into dotnet:inflight/current Sep 17, 2025
1 check passed

jfversluis added this to the .NET 9 SR12 milestone Sep 17, 2025

Tamilarasan-Paranthaman mentioned this pull request Sep 25, 2025

[.NET 10] Fix RadioButton Test Failure #31772

Merged

github-actions Bot locked and limited conversation to collaborators Oct 17, 2025

Conversation

asi-evin commented Aug 14, 2025

Description of Change

Issues Fixed

Uh oh!

asi-evin commented Aug 14, 2025

Uh oh!

Uh oh!

jfversluis commented Aug 19, 2025

Uh oh!

azure-pipelines Bot commented Aug 19, 2025

Uh oh!

jfversluis left a comment

Choose a reason for hiding this comment

Uh oh!

asi-evin commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asi-evin commented Aug 19, 2025

Uh oh!

azure-pipelines Bot commented Aug 19, 2025

Uh oh!

jfversluis commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Aug 20, 2025

Uh oh!

jfversluis commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Aug 21, 2025

Uh oh!

jfversluis left a comment

Choose a reason for hiding this comment

Uh oh!

asi-evin commented Aug 22, 2025

Uh oh!

MartyIX commented Aug 22, 2025

Uh oh!

asi-evin commented Aug 22, 2025

Uh oh!

asi-evin commented Sep 11, 2025

Uh oh!

azure-pipelines Bot commented Sep 12, 2025

Uh oh!

azure-pipelines Bot commented Sep 13, 2025

Uh oh!

asi-evin commented Sep 15, 2025

Uh oh!

Uh oh!

jfversluis commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

asi-evin commented Aug 19, 2025 •

edited

Loading

jfversluis commented Aug 20, 2025 •

edited

Loading

jfversluis commented Aug 21, 2025 •

edited

Loading