Skip to content

Fixes text centering causing offsets by some glyphs #31412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dotMorten wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes text centering causing offsets by some glyphs #31412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb5e7e3
Fixes text centering causing offsets by some glyphs
dotMorten Aug 29, 2025
e29d763
Update src/Core/src/ImageSources/FontImageSourceService/FontImageSour…
dotMorten Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Core/src/ImageSources/FontImageSourceService/FontImageSourceService.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,8 @@ internal CanvasImageSource RenderImageSource(IFontImageSource imageSource, float
var canvasImageSource = new CanvasImageSource(device, canvasWidth, canvasHeight, dpi);
using (var ds = canvasImageSource.CreateDrawingSession(UI.Colors.Transparent))
{
// offset by 1px as we added a 1px padding
var x = (layout.DrawBounds.X * -1) + 1;
var y = (layout.DrawBounds.Y * -1) + 1;
var x = (canvasWidth / 2d + (layout.LayoutBounds.Left + layout.DefaultFontSize / 2));
var y = (canvasHeight / 2d + (layout.LayoutBounds.Top + layout.DefaultFontSize / 2));

ds.DrawTextLayout(layout, (float)x, (float)y, color);
}
Expand Down Expand Up @@ -149,4 +148,4 @@ string GetFontSource(IFontImageSource imageSource)
return fontSource;
}
}
}
}
Loading