-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Windows, Catalyst] Fix IsPresented=true Not Working on Initial Value in FlyoutPage #31515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cacf32f
mac fix added
devanathan-vaithiyanathan ba743b9
Windows fix added
devanathan-vaithiyanathan 7f5db87
test case added
devanathan-vaithiyanathan c6c7b88
Update Issue31372.cs
devanathan-vaithiyanathan 0e7a7bf
Update Issue31372.cs
devanathan-vaithiyanathan 37fc2b2
Update WindowHandler.iOS.cs
devanathan-vaithiyanathan 700afe0
fix updated
devanathan-vaithiyanathan 36128c0
Update WindowHandler.iOS.cs
devanathan-vaithiyanathan 4597846
Update WindowHandler.iOS.cs
devanathan-vaithiyanathan cf9293d
Update PublicAPI.Shipped.txt
devanathan-vaithiyanathan dce9403
changes added in UnShipped file
devanathan-vaithiyanathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 31372, "IsPresented=true Not Working on Initial Value in FlyoutPage", PlatformAffected.UWP | PlatformAffected.macOS)] | ||
|
|
||
| public class Issue31372 : NavigationPage | ||
| { | ||
| public Issue31372() | ||
| { | ||
| PushAsync(new Issue31372Page()); | ||
| } | ||
| } | ||
|
|
||
| public class Issue31372Page : FlyoutPage | ||
| { | ||
| public Issue31372Page() | ||
| { | ||
|
|
||
| // Create Flyout Page | ||
| var flyoutPage = new ContentPage | ||
| { | ||
| Title = "Flyout", | ||
| Content = new StackLayout | ||
| { | ||
| Children = | ||
| { | ||
| new Label | ||
| { | ||
| Text = "This is Flyout", | ||
| AutomationId = "FlyoutLabel" | ||
| } | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| // Create Detail Page | ||
| var detailPage = new ContentPage | ||
| { | ||
| Title = "Detailpage", | ||
| Content = new StackLayout | ||
| { | ||
| Padding = 16, | ||
| Spacing = 16, | ||
| Children = | ||
| { | ||
| new Label | ||
| { | ||
| Text = "This is Detail Page which displays additional information." | ||
| }, | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| // Assign Flyout and Detail | ||
| Flyout = flyoutPage; | ||
| Detail = new NavigationPage(detailPage); | ||
| FlyoutLayoutBehavior = FlyoutLayoutBehavior.Popover; | ||
| IsPresented = true; | ||
| } | ||
| } |
22 changes: 22 additions & 0 deletions
22
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31372.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues | ||
| { | ||
| public class Issue31372 : _IssuesUITest | ||
| { | ||
| public override string Issue => "IsPresented=true Not Working on Initial Value in FlyoutPage"; | ||
|
|
||
| public Issue31372(TestDevice device) | ||
| : base(device) | ||
| { } | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.FlyoutPage)] | ||
| public void VerifyIsPresentedInitialValue() | ||
| { | ||
| App.WaitForElement("FlyoutLabel"); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,12 +21,22 @@ protected override void ConnectHandler(RootNavigationView platformView) | |
| _navigationRootManager = MauiContext?.GetNavigationRootManager(); | ||
| platformView.PaneOpened += OnPaneOpened; | ||
| platformView.PaneClosed += OnPaneClosed; | ||
| platformView.Loaded += OnLoaded; | ||
| } | ||
|
|
||
| void OnLoaded(object sender, RoutedEventArgs e) | ||
| { | ||
| if (VirtualView is not null) | ||
| { | ||
| PlatformView.IsPaneOpen = VirtualView.IsPresented; | ||
| } | ||
| } | ||
|
Comment on lines
+27
to
33
|
||
|
|
||
| protected override void DisconnectHandler(RootNavigationView platformView) | ||
| { | ||
| platformView.PaneOpened -= OnPaneOpened; | ||
| platformView.PaneClosed -= OnPaneClosed; | ||
| platformView.Loaded -= OnLoaded; | ||
| } | ||
|
|
||
| void OnPaneOpened(NavigationView sender, object args) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ViewDidAppear()is much later in the lifecycle. Not a problem, but this could cause a visible delay where the flyout opens after the user sees the page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devanathan-vaithiyanathan if you do it via IUIViewLifeCycleEvents does ethat cause less delay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PureWeen , PhoneFlyoutPageRenderer is derived from UIViewController, not UIView. Therefore, overriding MovedToWindow isn’t possible, and invoking the MovedToWindow event handler isn’t applicable in this case.