[Testing] Fixed Test case failure in main branch#31733
[Testing] Fixed Test case failure in main branch#31733TamilarasanSF4853 wants to merge 4 commits intodotnet:mainfrom
Conversation
|
Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azo run MAUI-UITests-public |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a failing UI test case by adding platform-specific screenshot verification to handle rendering differences between Android and other platforms.
- Added platform-conditional screenshot verification with Android-specific cropping parameter to resolve test failures
- Updated the ButtonsLayoutResolveWhenParentSizeChangesSizeButtonsDownLandscape test case to improve cross-platform stability
| #if ANDROID | ||
| VerifyScreenshot(TestContext.CurrentContext.Test.MethodName + "SizeButtonsDownLandscape", cropLeft: 125); | ||
| #else | ||
| VerifyScreenshot(TestContext.CurrentContext.Test.MethodName + "SizeButtonsDownLandscape"); | ||
| #endif |
There was a problem hiding this comment.
The hardcoded crop value of 125 is a magic number without explanation. Consider adding a comment explaining why this specific crop value is needed for Android or defining it as a named constant to improve maintainability.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
jsuarezruiz
left a comment
There was a problem hiding this comment.
No content. Can you review it?
|
This PR changes included via candidate PR: #31681 |
This PR addresses the UI test image failures that occurred in the main branch and includes updates to improve rendering and test stability across platforms.
Test cases: