Skip to content

[Testing] Fixed Test case failure in main branch#31733

Closed
TamilarasanSF4853 wants to merge 4 commits intodotnet:mainfrom
TamilarasanSF4853:fix-resaving-image
Closed

[Testing] Fixed Test case failure in main branch#31733
TamilarasanSF4853 wants to merge 4 commits intodotnet:mainfrom
TamilarasanSF4853:fix-resaving-image

Conversation

@TamilarasanSF4853
Copy link
Copy Markdown
Contributor

This PR addresses the UI test image failures that occurred in the main branch and includes updates to improve rendering and test stability across platforms.

  • Replaced snapshots for ButtonsLayoutResolveWhenParentSizeChangesSizeButtonsDownLandscape test case

Test cases:

  • ButtonsLayoutResolveWhenParentSizeChangesSizeButtonsDownLandscape

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 23, 2025
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Sep 23, 2025
@sheiksyedm sheiksyedm added the area-testing Unit tests, device tests label Sep 23, 2025
@rmarinho
Copy link
Copy Markdown
Member

/azo run MAUI-UITests-public

@TamilarasanSF4853 TamilarasanSF4853 marked this pull request as ready for review September 23, 2025 18:34
Copilot AI review requested due to automatic review settings September 23, 2025 18:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a failing UI test case by adding platform-specific screenshot verification to handle rendering differences between Android and other platforms.

  • Added platform-conditional screenshot verification with Android-specific cropping parameter to resolve test failures
  • Updated the ButtonsLayoutResolveWhenParentSizeChangesSizeButtonsDownLandscape test case to improve cross-platform stability

Comment on lines +35 to +39
#if ANDROID
VerifyScreenshot(TestContext.CurrentContext.Test.MethodName + "SizeButtonsDownLandscape", cropLeft: 125);
#else
VerifyScreenshot(TestContext.CurrentContext.Test.MethodName + "SizeButtonsDownLandscape");
#endif
Copy link

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded crop value of 125 is a magic number without explanation. Consider adding a comment explaining why this specific crop value is needed for Android or defining it as a named constant to improve maintainability.

Copilot uses AI. Check for mistakes.
@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No content. Can you review it?

@sheiksyedm sheiksyedm closed this Sep 24, 2025
@sheiksyedm
Copy link
Copy Markdown
Contributor

sheiksyedm commented Sep 24, 2025

This PR changes included via candidate PR: #31681

@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2025
@TamilarasanSF4853 TamilarasanSF4853 deleted the fix-resaving-image branch March 23, 2026 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants