-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Implement screenshot cropping based on device orientation #31737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ahamed-Ali
wants to merge
12
commits into
dotnet:main
Choose a base branch
from
Ahamed-Ali:VerifyScreenShotCropOnOrientation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
462d0e5
Crop the image based on the Landscape
Ahamed-Ali 66d090b
Removed the left and right params
Ahamed-Ali ad84e4c
Change to if condition
Ahamed-Ali d56182d
Resolve the conflicts
Ahamed-Ali f83e229
Address the test failures and added pending snap
Ahamed-Ali 82f0d60
Change this to IOSUITest
Ahamed-Ali 3dd8e41
Committed the pending snaps
Ahamed-Ali 00dbdd5
Removed cropLeft from test cases as it handled it in the UITest sourc…
Ahamed-Ali 0ccda2e
changed based on main latest
Ahamed-Ali 51286be
Update UITest.cs
Ahamed-Ali 48066fb
Optimized the code
Ahamed-Ali d68d143
Added Proper crop images
Ahamed-Ali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+18.1 KB
(300%)
...droid.Tests/snapshots/android/BorderBackgroundSizeUpdatesWhenRotatingScreen.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+12.2 KB
(140%)
...s/android/ButtonsLayoutResolveWhenParentSizeChangesSizeButtonsDownLandscape.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.24 KB
(120%)
...stCases.Android.Tests/snapshots/android/CarouselViewItemShouldScaleProperly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+17.9 KB
(150%)
...Android.Tests/snapshots/android/HorizontalStackLayout_Spacing_WithLandscape.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.56 KB
(94%)
...tCases.Android.Tests/snapshots/android/Issue32394CurrentItemShouldnotChange.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+47.5 KB
(150%)
.../TestCases.Android.Tests/snapshots/android/ShouldFlyoutTextWrapsInLandscape.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+47.4 KB
(160%)
...roid.Tests/snapshots/android/ToolbarExtendsAllTheWayLeftAndRight_FlyoutPage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+47.7 KB
(170%)
....Tests/snapshots/android/ToolbarExtendsAllTheWayLeftAndRight_NavigationPage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+57.6 KB
(180%)
...s.Android.Tests/snapshots/android/ToolbarExtendsAllTheWayLeftAndRight_Shell.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+13.6 KB
(130%)
...s.Android.Tests/snapshots/android/VerticalStackLayout_Spacing_WithLandscape.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+1.27 KB
(110%)
...Cases.iOS.Tests/snapshots/ios/BorderBackgroundSizeUpdatesWhenRotatingScreen.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.2 KB
(100%)
...shots/ios/ButtonsLayoutResolveWhenParentSizeChangesSizeButtonsDownLandscape.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.47 KB
(120%)
...tests/TestCases.iOS.Tests/snapshots/ios/CarouselViewItemShouldScaleProperly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+990 Bytes
(110%)
...rols/tests/TestCases.iOS.Tests/snapshots/ios/FlyoutOverlayResizesOnRotation.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+39.2 KB
(320%)
...stCases.iOS.Tests/snapshots/ios/HorizontalStackLayout_Spacing_WithLandscape.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+26 KB
(120%)
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue28657_Landscape.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.24 KB
(100%)
...ests/TestCases.iOS.Tests/snapshots/ios/Issue32394CurrentItemShouldnotChange.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+24.1 KB
(120%)
...ls/tests/TestCases.iOS.Tests/snapshots/ios/ShouldFlyoutTextWrapsInLandscape.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+14.3 KB
(110%)
...ases.iOS.Tests/snapshots/ios/ToolbarExtendsAllTheWayLeftAndRight_FlyoutPage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8.13 KB
(110%)
....iOS.Tests/snapshots/ios/ToolbarExtendsAllTheWayLeftAndRight_NavigationPage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+7 KB
(110%)
...TestCases.iOS.Tests/snapshots/ios/ToolbarExtendsAllTheWayLeftAndRight_Shell.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+43 KB
(310%)
...TestCases.iOS.Tests/snapshots/ios/VerticalStackLayout_Spacing_WithLandscape.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.