-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] - Implement WindowInsetListener for per coordinator layout #31898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
NirmalKumarYuvaraj
wants to merge
6
commits into
dotnet:main
from
NirmalKumarYuvaraj:SafeAreaFollowUp
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3262e3e
navigation page
NirmalKumarYuvaraj 3f7fbd9
shell and more changes
NirmalKumarYuvaraj a6b3507
more changes
NirmalKumarYuvaraj ea77478
more changes
NirmalKumarYuvaraj f5c17f4
optimized connect and disconnect logics
NirmalKumarYuvaraj 910f44e
fixed test failures
NirmalKumarYuvaraj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,6 +15,8 @@ | |||||||||
| using AndroidX.ViewPager2.Widget; | ||||||||||
| using Google.Android.Material.Tabs; | ||||||||||
| using Microsoft.Extensions.Logging; | ||||||||||
| using Microsoft.Maui.Platform; | ||||||||||
| using Google.Android.Material.AppBar; | ||||||||||
| using AToolbar = AndroidX.AppCompat.Widget.Toolbar; | ||||||||||
| using AView = Android.Views.View; | ||||||||||
|
|
||||||||||
|
|
@@ -75,6 +77,8 @@ void AView.IOnClickListener.OnClick(AView v) | |||||||||
| IShellToolbarTracker _toolbarTracker; | ||||||||||
| ViewPager2 _viewPager; | ||||||||||
| bool _disposed; | ||||||||||
| GlobalWindowInsetListener _localInsetListener; | ||||||||||
| CoordinatorLayout _managedCoordinatorLayout; | ||||||||||
|
Comment on lines
+80
to
+81
|
||||||||||
| GlobalWindowInsetListener _localInsetListener; | |
| CoordinatorLayout _managedCoordinatorLayout; | |
| GlobalWindowInsetListener? _localInsetListener; | |
| CoordinatorLayout? _managedCoordinatorLayout; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields should be marked with
?to indicate nullability since they are assigned conditionally in OnCreateView() and set to null in Destroy(). This should beGlobalWindowInsetListener? _localInsetListener;andCoordinatorLayout? _managedCoordinatorLayout;.