Skip to content

[ci] Revert changes setting Creator #32743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 1 commit into from
Nov 19, 2025
Merged

[ci] Revert changes setting Creator #32743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/helix.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<HelixBuild>$(BUILD_BUILDNUMBER)</HelixBuild>
<HelixBuild Condition="'$(HelixBuild)' == ''">default</HelixBuild>
<HelixTargetQueues>Windows.10.Amd64.Open;osx.15.arm64.maui.open</HelixTargetQueues>
<Creator Condition="'$(Creator)' == ''">maui</Creator>
<Creator Condition="'$(HelixAccessToken)' == ''">maui</Creator>
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition logic appears inverted. Setting Creator='maui' when HelixAccessToken is empty may cause authentication issues. Typically, Creator should be set when an access token IS provided (authenticated scenarios), not when it's missing (anonymous scenarios). Consider changing the condition to Condition="'$(HelixAccessToken)' != ''" or verify this is the intended behavior.

Suggested change
<Creator Condition="'$(HelixAccessToken)' == ''">maui</Creator>
<Creator Condition="'$(HelixAccessToken)' != ''">maui</Creator>

Copilot uses AI. Check for mistakes.
<IncludeDotNetCli>true</IncludeDotNetCli>
<DotNetCliPackageType>sdk</DotNetCliPackageType>
<EnableAzurePipelinesReporter>true</EnableAzurePipelinesReporter>
Expand Down
Loading