Skip to content

Enable CoreCLR Apple template tests#33231

Merged
PureWeen merged 20 commits intonet11.0from
feature/coreclr-apple-template-tests-helix
Mar 24, 2026
Merged

Enable CoreCLR Apple template tests#33231
PureWeen merged 20 commits intonet11.0from
feature/coreclr-apple-template-tests-helix

Conversation

@kotlarmilos
Copy link
Copy Markdown
Member

Description

This PR enables CoreCLR Apple template tests on Helix, mirroring the existing Android CoreCLR tests implementation.

Contributes to dotnet/runtime#120056

Copilot AI review requested due to automatic review settings December 19, 2025 08:27
@kotlarmilos kotlarmilos self-assigned this Dec 19, 2025
@kotlarmilos kotlarmilos requested a review from rmarinho December 19, 2025 08:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables CoreCLR Apple template tests on Helix for iOS simulator, adding test coverage for the CoreCLR runtime variant alongside existing Mono and NativeAOT tests. This work contributes to runtime issue #120056 by providing integration test validation for CoreCLR on Apple platforms.

Key Changes:

  • Adds CoreCLR to the RuntimeVariant enum
  • Introduces CoreCLR test cases for both "maui" and "maui-blazor" templates in Debug and Release configurations
  • Configures CoreCLR builds with the UseMonoRuntime=false property
  • Enhances pipeline test result reporting with explicit error handling configuration

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/TestUtils/src/Microsoft.Maui.IntegrationTests/BaseBuildTest.cs Adds CoreCLR enum value to RuntimeVariant enum for distinguishing CoreCLR runtime tests
src/TestUtils/src/Microsoft.Maui.IntegrationTests/AppleTemplateTests.cs Adds four new test cases for CoreCLR runtime (Debug/Release for maui and maui-blazor templates) and implements CoreCLR build configuration by setting UseMonoRuntime=false
eng/pipelines/arcade/stage-integration-tests.yml Explicitly configures error handling with continueOnError: false and failTaskOnFailedTests: true to ensure test failures are properly reported

@rmarinho
Copy link
Copy Markdown
Member

/rebase

@rmarinho
Copy link
Copy Markdown
Member

rmarinho commented Feb 9, 2026

/rebase

@kotlarmilos
Copy link
Copy Markdown
Member Author

Tests are passing. Maccatalyst test is failing due to a version mismatch: object built for 15.2 but linked against 15.0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 27, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33231

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33231"

@rolfbjarne
Copy link
Copy Markdown
Member

/azp run maui-pr-devicetests,maui-pr-uitests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@kotlarmilos
Copy link
Copy Markdown
Member Author

The template tests are passing. The device tests are failing due to missing debug libraries in Release build. It seems that CoreCLR has hard load-time dependency even they are not being used.

Tracked in dotnet/macios#24849

@rolfbjarne rolfbjarne removed the do-not-merge Don't merge this PR label Mar 18, 2026
@rolfbjarne rolfbjarne self-assigned this Mar 18, 2026
@kotlarmilos
Copy link
Copy Markdown
Member Author

It seems that the template tests have passed on CoreCLR

/cc: @rolfbjarne @PureWeen

@rolfbjarne
Copy link
Copy Markdown
Member

/azp run maui-pr-uitests,maui-pr-devicetests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@kotlarmilos
Copy link
Copy Markdown
Member Author

iOS tests passed. Maccatalyst tests are timing out, let's rerun the job

Copy link
Copy Markdown
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but someone else more familiar with the codebase should also approve.

@kubaflo
Copy link
Copy Markdown
Contributor

kubaflo commented Mar 23, 2026

/azp run maui-pr-uitests,maui-pr-devicetests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@kotlarmilos
Copy link
Copy Markdown
Member Author

kotlarmilos commented Mar 24, 2026

Maccatalyst UI tests are pre-existing and unrelated

@PureWeen PureWeen merged commit 7a70dce into net11.0 Mar 24, 2026
198 of 214 checks passed
@PureWeen PureWeen deleted the feature/coreclr-apple-template-tests-helix branch March 24, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants