Enable CoreCLR Apple template tests#33231
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables CoreCLR Apple template tests on Helix for iOS simulator, adding test coverage for the CoreCLR runtime variant alongside existing Mono and NativeAOT tests. This work contributes to runtime issue #120056 by providing integration test validation for CoreCLR on Apple platforms.
Key Changes:
- Adds
CoreCLRto theRuntimeVariantenum - Introduces CoreCLR test cases for both "maui" and "maui-blazor" templates in Debug and Release configurations
- Configures CoreCLR builds with the
UseMonoRuntime=falseproperty - Enhances pipeline test result reporting with explicit error handling configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/TestUtils/src/Microsoft.Maui.IntegrationTests/BaseBuildTest.cs |
Adds CoreCLR enum value to RuntimeVariant enum for distinguishing CoreCLR runtime tests |
src/TestUtils/src/Microsoft.Maui.IntegrationTests/AppleTemplateTests.cs |
Adds four new test cases for CoreCLR runtime (Debug/Release for maui and maui-blazor templates) and implements CoreCLR build configuration by setting UseMonoRuntime=false |
eng/pipelines/arcade/stage-integration-tests.yml |
Explicitly configures error handling with continueOnError: false and failTaskOnFailedTests: true to ensure test failures are properly reported |
src/TestUtils/src/Microsoft.Maui.IntegrationTests/AppleTemplateTests.cs
Outdated
Show resolved
Hide resolved
src/TestUtils/src/Microsoft.Maui.IntegrationTests/AppleTemplateTests.cs
Outdated
Show resolved
Hide resolved
…-apple-template-tests-helix
…-apple-template-tests-helix
…reclr-apple-template-tests-helix
…-apple-template-tests-helix
…-apple-template-tests-helix
|
/rebase |
…-apple-template-tests-helix
…-apple-template-tests-helix
|
/rebase |
…-apple-template-tests-helix
…-apple-template-tests-helix
|
Tests are passing. Maccatalyst test is failing due to a version mismatch: object built for 15.2 but linked against 15.0 |
…-apple-template-tests-helix
…-apple-template-tests-helix
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33231Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33231" |
…ple-template-tests-helix
|
/azp run maui-pr-devicetests,maui-pr-uitests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The template tests are passing. The device tests are failing due to missing debug libraries in Release build. It seems that CoreCLR has hard load-time dependency even they are not being used. Tracked in dotnet/macios#24849 |
…ple-template-tests-helix
|
It seems that the template tests have passed on CoreCLR /cc: @rolfbjarne @PureWeen |
|
/azp run maui-pr-uitests,maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
iOS tests passed. Maccatalyst tests are timing out, let's rerun the job |
rolfbjarne
left a comment
There was a problem hiding this comment.
This looks good to me, but someone else more familiar with the codebase should also approve.
|
/azp run maui-pr-uitests,maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Maccatalyst UI tests are pre-existing and unrelated |
Description
This PR enables CoreCLR Apple template tests on Helix, mirroring the existing Android CoreCLR tests implementation.
Contributes to dotnet/runtime#120056