Skip to content

[UIKit] Avoid useless measure invalidation propagation cycles#33459

Open
albyrock87 wants to merge 1 commit intodotnet:mainfrom
albyrock87:ios-avoid-useless-invalidation-propagation
Open

[UIKit] Avoid useless measure invalidation propagation cycles#33459
albyrock87 wants to merge 1 commit intodotnet:mainfrom
albyrock87:ios-avoid-useless-invalidation-propagation

Conversation

@albyrock87
Copy link
Copy Markdown
Contributor

Description of Change

image

Invalidation propagation can be quite consuming especially when switching binding context and multiple properties change (i.e. having multiple labels inside a layout, all of them changing the text).

Ti PR avoids useless propagations (same behavior requestLayout intrinsically has on Android).

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 10, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Hey there @@albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Jan 12, 2026

/azp run maui-pr-uitests

@dotnet dotnet deleted a comment from azure-pipelines bot Jan 12, 2026
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@kubaflo
Copy link
Copy Markdown
Contributor

kubaflo commented Jan 17, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo
Copy link
Copy Markdown
Contributor

kubaflo commented Jan 17, 2026

I'm reviewing this PR and noticed the iOS CollectionView2 test failed. Is this a known flaky test, or could this be related to the measure invalidation optimization changes?

@albyrock87
Copy link
Copy Markdown
Contributor Author

albyrock87 commented Jan 18, 2026

It may have broken it, interesting, I'll look into it, thanks @kubaflo

@kubaflo
Copy link
Copy Markdown
Contributor

kubaflo commented Mar 22, 2026

@albyrock87 what's the status of this PR? Do you think it is still needed? If so, can you please resolve conflicts?

@albyrock87
Copy link
Copy Markdown
Contributor Author

@albyrock87 what's the status of this PR? Do you think it is still needed? If so, can you please resolve conflicts?

@kubaflo yes I think this is needed.
I'm really overwhelmed right now.
Hopefully I can get back to this in a couple of weeks. Thanks

@MauiBot
Copy link
Copy Markdown
Collaborator

MauiBot commented Apr 5, 2026

⚠️ Merge Conflict Detected — This PR has merge conflicts with its target branch. Please rebase onto the target branch and resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community ✨ Community Contribution

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

5 participants