Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates localized .resx.lcl resources for the .NET MAUI controls source generator, adding translations for new binding-related diagnostic messages and NameScope errors across multiple languages. The goal is to keep localized error and warning strings in sync with the underlying English resources.
Changes:
- Added localized strings (binding compilation failures, warnings, indexer issues, and property-not-found diagnostics) to
MauiGResources.resx.lclfor many languages (zh-Hant, zh-Hans, tr, ru, pt-BR, pl, ko, ja, it, fr, es, de, cs). - Added localized NameScope-related error messages (
NamescopeDuplicate,NamescopeError) for the same set of languages. - Ensured links and placeholders (
{0},{1}) are generally preserved and correctly ordered in the localized messages.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
loc/zh-Hant/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Traditional Chinese translations for binding diagnostics and NameScope errors. |
loc/zh-Hans/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Simplified Chinese translations for the same new binding and NameScope messages. |
loc/tr/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Turkish translations for binding and NameScope diagnostics; one sentence still contained an English fragment, which was flagged. |
loc/ru/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Russian translations for new binding-related and NameScope error messages. |
loc/pt-BR/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Brazilian Portuguese translations for binding and NameScope diagnostics. |
loc/pl/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Polish translations for binding diagnostics and NameScope errors. |
loc/ko/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Korean translations for binding and NameScope messages; an extra ] character in one error string was reported. |
loc/ja/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Japanese translations for binding-related and NameScope diagnostics. |
loc/it/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Italian translations for binding diagnostics and NameScope errors. |
loc/fr/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds French translations for binding-related and NameScope error messages. |
loc/es/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Spanish translations for binding diagnostics and NameScope errors. |
loc/de/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds German translations for binding-related diagnostics and NameScope messages. |
loc/cs/src/Controls/src/SourceGen/MauiGResources.resx.lcl |
Adds Czech translations for binding diagnostics and NameScope errors. |
| <Str Cat="Text"> | ||
| <Val><![CDATA[Binding: Unsupported indexer index type: "{0}".]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[바인딩: 지원되지 않는 인덱서 인덱스 형식: "{0}"]]></Val> |
There was a problem hiding this comment.
In this Korean translation string there appears to be an extra closing bracket character (]) after the placeholder ("{0}"), which will show up in the user-facing error message and does not match the source text; please remove the stray ] so that the message ends cleanly after the placeholder.
Suggested change
| <Val><![CDATA[바인딩: 지원되지 않는 인덱서 인덱스 형식: "{0}"]]></Val> | |
| <Val><![CDATA[바인딩: 지원되지 않는 인덱서 인덱스 형식: "{0}".]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[Binding might be compiled incorrectly since the x:DataType annotation comes from an outer scope. Make sure you annotate all DataTemplate XAML elements with the correct x:DataType. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[x:DataType ek açıklaması bir dış kapsamdan geldiğinden bağlama yanlış derlenmiş olabilir. Tüm DataTemplate XAML öğelerine doğru x:DataType ile not eklediğinizden emin olun. Bkz. https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information.]]></Val> |
There was a problem hiding this comment.
In this Turkish translation, the last sentence mixes Turkish and English ("for more information"), which reads unpolished in the localized UI; please fully localize that clause so the entire sentence is in Turkish while keeping the URL unchanged.
Suggested change
| <Val><![CDATA[x:DataType ek açıklaması bir dış kapsamdan geldiğinden bağlama yanlış derlenmiş olabilir. Tüm DataTemplate XAML öğelerine doğru x:DataType ile not eklediğinizden emin olun. Bkz. https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information.]]></Val> | |
| <Val><![CDATA[x:DataType ek açıklaması bir dış kapsamdan geldiğinden bağlama yanlış derlenmiş olabilir. Tüm DataTemplate XAML öğelerine doğru x:DataType ile not eklediğinizden emin olun. Daha fazla bilgi için bkz. https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings.]]></Val> |
rmarinho
approved these changes
Feb 2, 2026
rmarinho
deleted the
lego/hb_aa4ddd3b-37ca-4d87-a058-1e95d9ca2d38_20260201193844071
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_aa4ddd3b-37ca-4d87-a058-1e95d9ca2d38_20260201193844071 to net10.0 with localized lcls