[Android/iOS] Fix CollectionView not respecting SafeAreaEdges settings

[praveenkumarkarunanithi]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause

Android:
CollectionView uses RecyclerView which implements IMauiRecyclerView. When individual item views within the ItemTemplate have explicit SafeAreaEdges settings (e.g., <Grid SafeAreaEdges="Container,None">), these item views were excluded from receiving window inset listeners because of the || view is IMauiRecyclerView check in FindListenerForView(). This prevented per-item safe area control within CollectionView items.

iOS:
CollectionView uses UICollectionView, which inherits from UIScrollView. The RespondsToSafeArea() check excluded all UIScrollView descendants, preventing CollectionView cell content views from responding to safe area. Additionally, cell content views never receive SafeAreaInsetsDidChange() notifications during orientation changes, causing their SafeAreaInsets property to remain stale.

Description of Change

Android:
Removed the || parent is IMauiRecyclerView exclusion from FindListenerForView(). RecyclerView child views (CollectionView item views) can now receive window inset listeners, enabling SafeAreaEdges on individual item templates.

iOS:
Added an exception in RespondsToSafeArea() so that UICollectionView descendants respond to safe area even though they inherit from UIScrollView. For CollectionView descendants, Window.SafeAreaInsets is used instead of this.SafeAreaInsets to obtain current safe area values during layout. In CrossPlatformArrange(), safe area revalidation is forced when window insets change (such as during orientation changes), ensuring CollectionView cell content views update correctly.

Issues Fixed

Fixes #33604

Platforms Tested

• iOS
• Android
• Windows
• Mac

Note: Test scoped to iOS only — Android CI devices lack notch/cutout hardware, so SafeArea screenshot differences are not observable on that platform.

iOS Screenshots

Before Fix	After Fix
iOS-withoutfix.1.mov	iOS-withfix.1.mov

Android Screenshots

Before Fix	After Fix
Android-withoutfix.mov	Android-withfix.mov

[Copilot]

Pull request overview

This PR fixes issue #33604 where CollectionView does not respect SafeAreaEdges settings on individual item templates. The issue manifested differently on Android (regression from 10.0.1 to 10.0.30) and iOS (never worked correctly). The fix enables per-item SafeAreaEdges control within CollectionView/CarouselView items on both platforms.

Changes:

• Android: Removed IMauiRecyclerView exclusion from window inset listener lookup, allowing RecyclerView child views (CollectionView items) to receive inset listeners
• iOS: Added UICollectionView exception to safe area handling so CollectionView cells can respond to safe area, using Window.SafeAreaInsets to work around iOS notification limitations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Core/src/Platform/iOS/MauiView.cs	Added UICollectionView exception in RespondsToSafeArea(), implemented Window.SafeAreaInsets fallback for CollectionView cells, added safe area revalidation logic during orientation changes
src/Core/src/Platform/Android/MauiWindowInsetListener.cs	Removed IMauiRecyclerView exclusion from FindListenerForView() to enable per-item SafeAreaEdges control

[kubaflo]

Could you please resolve conflicts?

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33908

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33908"

[praveenkumarkarunanithi]

Could you please resolve conflicts?

Conflicts have been resolved and the branch has been updated accordingly.

[sheiksyedm]

/azp run maui-pr-uitests , maui-pr-devicetests

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[AlleSchonWeg]

Hi,
i have a question to this PR.
Will the fix also works for other CollectionViews? From DevExpress and Syncfusion? Or only Maui CollectionViews?

[praveenkumarkarunanithi]

📋 PR Finalization Review

Title: ✅ Good

Current: [Android/iOS] Fix CollectionView not respecting SafeAreaEdges settings

Description: ✅ Good

The description is well-structured with:

• ✅ NOTE block present for artifact testing
• ✅ Separate root cause analysis for Android and iOS
• ✅ Clear description of changes per platform
• ✅ Issues Fixed section referencing CollectionView does not respect content SafeAreaEdges choices (Regression for Android, different problem in iOS) #33604
• ✅ Before/after video screenshots for both platforms
• ✅ Platforms tested checklist

Only concern: PR diff includes ~15 unrelated files from merging upstream/main (.github/, eng/, TypedBinding changes from #34428). Consider rebasing to focus the diff on the actual CollectionView SafeArea fix.

Code Review: ⚠️ Issues Found

🟡 Suggestions

1. Consider pixel-level comparison for Window insets change detection

• File: src/Core/src/Platform/iOS/MauiView.cs (line ~552 in CrossPlatformArrange)
• Current code: !currentWindowInsets.Equals(_lastWindowSafeAreaInsets) uses exact UIEdgeInsets struct comparison
• Concern: The codebase convention is EqualsAtPixelLevel() for safe area comparisons (used in ValidateSafeArea() at line 692 and MauiScrollView.cs:406) to absorb sub-pixel animation noise. While the downstream ValidateSafeArea() has pixel-level protection preventing oscillation, using exact comparison here triggers unnecessary ValidateSafeArea() recalculation calls during animation transitions.
• Suggestion: Convert UIEdgeInsets to SafeAreaPadding (via ToSafeAreaInsets()) and use EqualsAtPixelLevel() for consistency:

var currentWindowPadding = currentWindowInsets.ToSafeAreaInsets();
if (!currentWindowPadding.EqualsAtPixelLevel(_lastWindowSafeAreaPadding))

2. No automated tests for the CollectionView SafeArea fix

• The core fix for CollectionView does not respect content SafeAreaEdges choices (Regression for Android, different problem in iOS) #33604 (Android inset listener + iOS safe area for CollectionView) has no UI tests
• The TypedBinding tests in the diff are from a separate merged fix ([Regression] 10.0.50: Compiled Bindings (TypedBinding) does not resubscribe to intermediary values #34428)
• Consider adding a UI test that verifies CollectionView item content respects SafeAreaEdges settings (e.g., content not rendering under the notch)

3. Merge noise from upstream/main

• PR includes ~15 unrelated files (.github/, eng/, TypedBinding.cs, TypedBindingUnitTests.cs) from merging upstream/main into the feature branch
• This makes the diff harder to review. Consider rebasing onto the target branch (inflight/current) to keep the diff focused

4. Minor: trailing double blank line

• File: src/Core/src/Platform/iOS/MauiView.cs (around line 318)
• Two consecutive blank lines after the ternary in GetAdjustedSafeAreaInsets() — minor style nit

✅ Looks Good

• Android change is surgical and safe — removing || parent is IMauiRecyclerView from FindListenerForView() is minimal and well-commented. The comment about performance overhead being negligible is appreciated
• iOS RespondsToSafeArea() logic is correct — properly distinguishes UICollectionView from regular UIScrollView using scrollViewParent is not UICollectionView
• Cache invalidation is complete — _collectionViewDescendant, _lastWindowSafeAreaInsets, and _scrollViewDescendant are all properly cleared in MovedToWindow()
• Null-safe nullable bool access — _collectionViewDescendant == true correctly handles the bool? type (null and false both evaluate to false)
• TypedBinding Subscribe() idempotency claim is verified — The PropertyChangedProxy.Part setter uses ReferenceEquals to skip if already subscribed to the same source, confirming the "safe to call repeatedly" comment
• Window.SafeAreaInsets as data source for CollectionView cells is a reasonable trade-off — cells do not receive SafeAreaInsetsDidChange notifications, so using window-level insets (which always reflect current orientation) is the correct workaround

Addressed AI summary review concerns, and added a UI test for CollectionView SafeArea validation (iOS only).

[MauiBot]

🤖 AI Summary

📊 Expand Full Review — 92d702a · updated test and addressed AI agent concerns.

---

🔍 Pre-Flight — Context & Validation

---

Issue: #33604 - CollectionView does not respect content SafeAreaEdges choices (Regression for Android, different problem in iOS)
PR: #33908 - [Android/iOS] Fix CollectionView not respecting SafeAreaEdges settings
Platforms Affected: Android, iOS
Files Changed: 2 implementation, 2 test, 1 snapshot

Key Findings

• The linked issue describes two different failures: Android regressed in 10.0.10 and lets CollectionView item content render under system bars, while iOS keeps both background and content inside the safe area instead of allowing container/background bleed.
• The PR changes Android and iOS platform code plus adds an iOS-only UI test (Issue33604) and baseline screenshot; the PR description explicitly notes Android notch/cutout validation is not observable on CI devices.
• Prior review feedback asked for pixel-level safe-area comparison consistency and automated test coverage; the author replied that the concerns were addressed and added the iOS UI test.
• An open PR discussion question asks whether the fix helps third-party CollectionView implementations (for example DevExpress or Syncfusion); there is no visible answer yet.
• Current PR checks are still running, while Windows Helix unit test lanes are red; those failures do not appear tied to the 5-file PR diff from GitHub.

Edge Cases From Discussion

• iOS behavior was reported as reproducible on iOS 26.1 but not on iOS 18.0 or 26.0 in issue validation comments, so orientation/safe-area timing differences across OS versions matter.
• The desired behavior is mixed: CollectionView item backgrounds should extend edge-to-edge while inner content still respects safe area when SafeAreaEdges="Container,None" is used inside item templates.
• PR comments imply collection-view descendants need special handling without regressing ordinary UIScrollView descendant behavior.

File Classification

• Implementation:
  • src/Core/src/Platform/Android/MauiWindowInsetListener.cs
  • src/Core/src/Platform/iOS/MauiView.cs
• UI test assets:
  • src/Controls/tests/TestCases.HostApp/Issues/Issue33604.cs
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33604.cs
  • src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/CollectionViewItemsShouldRespectSafeAreaEdges.png

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #33908	Android: allow RecyclerView item descendants to receive inset listeners. iOS: let UICollectionView descendants participate in safe-area handling and revalidate using window safe-area padding during layout/orientation PENDING (Gate)	MauiWindowInsetListener.cs, MauiView.cs, Issue33604.cs (HostApp/UI test), snapshot	Original PR plus iOS-only UI regression test	changes.

---

🚦 Gate — Test Verification

---

Gate Result: PASSED

Platform: ios
Mode: Full Verification

• Tests FAIL without fix: yes
• Tests PASS with fix: yes

Evidence

• Used verify-tests-fail.ps1 with -FixFiles override to target the PR implementation files despite noisy local diff state.
• Verification report: CustomAgentLogsTmp/PRState/33908/PRAgent/gate/verify-tests-fail/verification-report.md
• The report records Tests WITHOUT fix | FAIL | FAIL | PASS and Tests WITH fix | PASS | PASS | PASS for Issue33604 on iOS.

---

🔧 Fix — Analysis & Comparison

---

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix (claude-opus-4.6)	Force CollectionView descendant invalidation in LayoutSubviews() and keep using per-cell SafeAreaInsets instead of window padding.	FAIL	src/Core/src/Platform/iOS/MauiView.cs	Functionally closer, but screenshot still differed by 5.88 percent, so it did not match the expected baseline.
2	try-fix (claude-sonnet-4.6)	Invalidate CollectionView descendants from TraitCollectionDidChange() while still using Window.SafeAreaInsets.	PASS	src/Core/src/Platform/iOS/MauiView.cs, src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt	Passed the screenshot, but it introduced a new override/API entry and a PublicAPI change, making it heavier than the PR fix.
3	try-fix (gpt-5.3-codex)	Propagate safe-area invalidation from ancestor SafeAreaInsetsDidChange() into UICollectionView descendants while relying on collection-parent/cell inset propagation.	FAIL	src/Core/src/Platform/iOS/MauiView.cs	Also failed the screenshot by 5.88 percent, reinforcing that ancestor/cell inset propagation alone does not match the expected layout.
4	try-fix (gemini-3-pro-preview)	Use a geometric Window.SafeAreaInsets intersection fallback for collection descendants instead of the PR's arrange-time cache/revalidation pattern.	FAIL	src/Core/src/Platform/iOS/MauiView.cs, src/Controls/tests/TestCases.Shared.Tests/UITest.cs	Still produced portrait-style/stale inset behavior in the test run and missed the screenshot baseline.
5	try-fix (gpt-5.3-codex, cross-pollination)	Hard-disable per-cell safe-area handling for UICollectionViewCell descendants and push compensation to the container chain only.	FAIL	src/Core/src/Platform/iOS/MauiView.cs, src/Core/src/Platform/iOS/MauiScrollView.cs	Test command failed before behavioral validation because the local baseline drifted into the known ImageMagick compile mismatch.
6	try-fix (gemini-3-pro-preview, cross-pollination)	Enable PreservesSuperviewLayoutMargins on UICollectionViewCell / ContentView to lean on UIKit inset propagation.	BLOCKED	src/Controls/src/Core/Handlers/Items2/iOS/ItemsViewCell2.cs	Also blocked by the same local ImageMagick compile drift before the idea could be behaviorally validated.
PR	PR #33908	Distinguish UICollectionView descendants from ordinary UIScrollView descendants, source CollectionView cell safe-area values from Window.SafeAreaInsets, and force revalidation during arrange when window padding changes.	PASSED (Gate)	src/Core/src/Platform/iOS/MauiView.cs, src/Core/src/Platform/Android/MauiWindowInsetListener.cs, Issue33604 UI test files	Original PR validated on iOS via full fail-without-fix / pass-with-fix gate verification.

Cross-Pollination

Model	Round	New Ideas?	Details
claude-opus-4.6	2	No	NO NEW IDEAS
claude-sonnet-4.6	2	No	NO NEW IDEAS
gpt-5.3-codex	2	Yes	NEW IDEA: For any MauiView/MauiScrollView inside a UICollectionViewCell, hard-disable per-cell safe-area application and apply compensation once at the UICollectionView container level only.
gemini-3-pro-preview	2	Yes	NEW IDEA: Enable PreservesSuperviewLayoutMargins on the UICollectionViewCell and its ContentView to rely on UIKit's native inset propagation mechanism.
claude-opus-4.6	3	No	NO NEW IDEAS
claude-sonnet-4.6	3	Yes	NEW IDEA: Drive compensation from the nearest UIViewController's ViewSafeAreaInsetsDidChange / UIViewController.View.SafeAreaInsets.
gpt-5.3-codex	3	Yes	NEW IDEA: Set ContentInsetAdjustmentBehavior = Never and apply Window safe area via FlowLayout.SectionInset manually.
gemini-3-pro-preview	3	No	NO NEW IDEAS

Exhausted: Yes - max 3 cross-pollination rounds reached.
Selected Fix: PR #33908 - It is the simplest passing implementation: validated by full gate verification, avoids the extra PublicAPI/API surface required by Attempt 2, and directly addresses both the stale inset source and invalidation timing problem for CollectionView cells.

---

📋 Report — Final Recommendation

---

Final Recommendation: APPROVE

Phase Status

Phase	Status	Notes
Pre-Flight	COMPLETE	Issue/PR context, file classification, discussion edge cases, and current check status documented.
Gate	PASSED	iOS full verification proved Issue33604 fails without the fix and passes with the fix.
Try-Fix	COMPLETE	6 attempts explored; 1 alternative passed, but it was heavier and expanded API surface compared to the PR fix.
Report	COMPLETE

Summary

PR #33908 fixes the iOS CollectionView safe-area regression by letting UICollectionView descendants participate in safe-area handling, using Window.SafeAreaInsets as the reliable source for CollectionView cell layout, and forcing revalidation when those window insets change. The new iOS UI regression test (Issue33604) correctly catches the bug: it failed without the fix and passed with the fix during gate verification.

Try-fix exploration found only one passing alternative: an event-driven TraitCollectionDidChange() version that still depended on Window.SafeAreaInsets. That alternative added a new override/API surface and required a PublicAPI update, making it less surgical than the PR's existing arrange-time revalidation approach. Other alternatives either consistently missed the screenshot baseline by 5.88 percent or were blocked by local baseline drift in the ImageMagick test dependency.

Root Cause

UICollectionView inherits from UIScrollView, so MAUI's existing iOS safe-area logic treated CollectionView descendants like ordinary scroll-view children and skipped their safe-area participation. On rotation, CollectionView cell content also does not reliably receive fresh per-cell SafeAreaInsets, leaving stale values in the cell subtree. Fixing the bug therefore requires both:

• an exception so CollectionView descendants are allowed to participate in safe-area handling, and
• a reliable source of current safe-area values plus a revalidation trigger when orientation/window insets change.

Fix Quality

The PR's fix is the best candidate from the review:

• It passed full fail-without-fix / pass-with-fix verification on iOS.
• It solves both parts of the root cause: descendant eligibility and stale safe-area values after rotation.
• It is more contained than the only passing alternative because it avoids adding new API/PublicAPI surface.
• The added UI regression test is appropriately scoped to iOS, where notch/cutout behavior is observable and relevant for this bug.

---

[github-actions]

🔍 Regression Risk Analysis

🟡 Overlaps found — This PR modifies files that were recently changed by bug-fix PRs, but does not revert their fix lines.

👍 / 👎 — Was this analysis helpful? React to let us know!

📊 Expand Full Analysis

File	Recent Fix PR	Fixed Issue	Risk
src/Core/src/Platform/iOS/MauiView.cs	#34024 — [iOS] Fix SafeArea infinite layout cycle with parent hierarchy walk and pixel-level comparison	#33595, #32586	🟡 Overlap
src/Core/src/Platform/iOS/MauiView.cs	#33526 — [iOS] SafeArea: Return Empty for non-ISafeAreaView views (opt-in model)	—	🟡 Overlap
src/Core/src/Platform/iOS/MauiView.cs	#32064 — Fix SafeAreaEdges.SoftInput applying bottom padding when keyboard is hidden	—	🟡 Overlap
src/Core/src/Platform/Android/MauiWindowInsetListener.cs	#33428 — [Android] Fix for TabbedPage BottomNavigation BarBackgroundColor not extending to system navigation bar	#33344	🟡 Overlap
src/Core/src/Platform/Android/MauiWindowInsetListener.cs	#32064 — Fix SafeAreaEdges.SoftInput applying bottom padding when keyboard is hidden	—	🟡 Overlap

Notes

• No revert risks detected. The specific lines removed by this PR (_scrollViewDescendant = this.GetParentOfType(UIScrollView)() is not null;, var baseSafeArea = SafeAreaInsets.ToSafeAreaInsets();, and the IMauiRecyclerView condition) were added by older PRs (Implement SafeAreaEdges property for per-edge safe area control #30337 and [Android] Refactor WindowInsetListener to per-view registry with MauiWindowInsetListener #32278 refactor), not by any of the recent bug-fix PRs listed above.
• The overlap with [iOS] Fix SafeArea infinite layout cycle with parent hierarchy walk and pixel-level comparison #34024 (safe area layout cycle fix) is worth noting — this PR intentionally modifies the _scrollViewDescendant logic to add a CollectionView exception. Verify that the IsParentHandlingSafeArea logic from [iOS] Fix SafeArea infinite layout cycle with parent hierarchy walk and pixel-level comparison #34024 still works correctly when a view is inside a UICollectionView.
• The removal of parent is IMauiRecyclerView from MauiWindowInsetListener.cs is intentional to enable per-item safe area control in CollectionView. Verify this doesn't regress the performance fix that originally added the IMauiRecyclerView exclusion in [Android] Refactor WindowInsetListener to per-view registry with MauiWindowInsetListener #32278.

Note

🔒 Integrity filtering filtered 5 items

Integrity filtering activated and filtered the following items during workflow execution.
This happens when a tool call accesses a resource that does not meet the required integrity or secrecy level of the workflow.

• pr:[Android/iOS] Fix CollectionView not respecting SafeAreaEdges settings #33908 (pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)
• pr:[iOS] Fix SafeArea infinite layout cycle with parent hierarchy walk and pixel-level comparison #34024 (pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)
• pr:Fix SafeAreaEdges.SoftInput applying bottom padding when keyboard is hidden and inset consumption issue #32064 (pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)
• pr:[Android] Refactor WindowInsetListener to per-view registry with MauiWindowInsetListener #32278 (pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)
• pr:[iOS] SafeArea: Return Empty for non-ISafeAreaView views (opt-in model) #33526 (pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)

🔍 Regression risk analysis by Find Regression Risk

[github-actions]

🔍 Prior Fix Regression Check

Result: ✅ No prior fix regressions detected

Checked deleted lines across implementation files. No lines were identified as reversions of prior bug fixes.

👍 / 👎 — Was this check helpful? React to let us know!

🔍 Regression check by Prior Fix Regression Check