Skip to content

Fix crash when closing Windows based app when using TitleBar #34032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 2 commits into from
Feb 27, 2026
+5 −1
Merged

Fix crash when closing Windows based app when using TitleBar #34032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89193da
fix: fixed crash when closing Windows based app when using TitleBar
MFinkBK Feb 13, 2026
28e772c
fix: moved setting AppWindowId earlier in Disconnect() and also call …
MFinkBK Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Core/src/Platform/Windows/NavigationRootManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public virtual void Connect(UIElement? platformView)
// Clear out the toolbar that was set from the previous content
SetToolbar(null);

// We need to make sure to clear out the root view content
// We need to make sure to clear out the root view content
// before creating the new view.
// Otherwise the new view might try to act on the old content.
// It might have code in the handler that retrieves this class.
Expand Down Expand Up @@ -147,6 +147,10 @@ public virtual void Disconnect()

SetToolbar(null);

_rootView.SetTitleBar(null, null);

_rootView.AppWindowId = null;

if (_rootView.Content is RootNavigationView navView)
navView.Content = null;

Expand Down
Loading