Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -390,13 +390,6 @@ public virtual void ScrollTo(ScrollToRequestEventArgs args)

var position = DetermineTargetPosition(args);

// The collection view includes a header at the zeroth index, so the collection view scrolling is not correct using the index.
bool hasHeader = ItemsViewAdapter.ItemsSource.HasHeader;
if (hasHeader)
{
position += 1;
}

if (args.IsAnimated)
{
ScrollHelper.AnimateScrollToPosition(position, args.ScrollToPosition);
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
using NUnit.Framework;
#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS // Issue: https://github.com/dotnet/maui/issues/26798

using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -20,4 +22,5 @@ public void VerifyCollectionViewVerticalOffset()
App.Tap("Empty");
Assert.That(App.FindElement("Label").GetText(), Is.EqualTo("0"));
}
}
}
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,7 @@ public void PageShouldNotScroll()
{
App.WaitForElement("EntNumber").GetRect();
App.WaitForElement("TopLabel").GetRect();
if (App is AppiumIOSApp iosApp && HelperExtensions.IsIOS26OrHigher(iosApp))
{
VerifyScreenshot(cropBottom: 1400);
}
else
{
VerifyScreenshot();
}
VerifyScreenshot(cropBottom: 1400);
}
}
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,10 @@ public void ValidateEntryClearButtonVisibilityBehavior()
App.DismissKeyboard();
#endif

if (App is AppiumIOSApp iosApp && HelperExtensions.IsIOS26OrHigher(iosApp))
{
VerifyScreenshot(cropBottom: 1400);
}
else
{
VerifyScreenshot();
}
#if IOS
VerifyScreenshot(cropBottom: 1400);
#else
VerifyScreenshot();
#endif
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,11 @@ public void EditorShouldNotMoveToBottom()
{
App.WaitForElement("Editor");
App.Tap("Editor");
if (App is AppiumIOSApp iosApp && HelperExtensions.IsIOS26OrHigher(iosApp))
{
VerifyScreenshot(cropBottom:1400);
}
else
{
VerifyScreenshot();
}
#if IOS
VerifyScreenshot(cropBottom: 1400);
#else
VerifyScreenshot();
#endif
}
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#if TEST_FAILS_ON_WINDOWS // NullReferenceException occurs when switching isGrouped to true
// refer to https://github.com/dotnet/maui/issues/28824
#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS && TEST_FAILS_ON_WINDOWS // NullReferenceException occurs when switching isGrouped to true
// refer to https://github.com/dotnet/maui/issues/29141, https://github.com/dotnet/maui/issues/28824
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@ public void CollectionViewInsideCarouselViewShouldNotThrowIndexOutOfRangeExcepti
// but the issue can be consistently reproduced manually with each scroll.
App.ScrollDown("MainCollectionView", ScrollStrategy.Gesture, 0.99, swipeSpeed: 50, true);
App.ScrollDown("MainCollectionView", ScrollStrategy.Gesture, 0.99, swipeSpeed: 50, true);
#if MACCATALYST
// MacCatalyst needs more scroll gestures to reach the bottom.
for (int i = 0; i < 5; i++)
{
App.ScrollDown("MainCollectionView", ScrollStrategy.Gesture, 0.99, swipeSpeed: 50, true);

if (App.FindElements("Footer").Count > 0)
break;
}
#endif
App.ScrollTo("Footer");
App.WaitForElement("Footer");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public Issue32223(TestDevice testDevice) : base(testDevice)
public override string Issue => "[Android] CollectionView items do not reorder correctly when using an item DataTemplateSelector";

[Test]
[Retry(5)]
[Category(UITestCategories.CollectionView)]
public void CanReorderWithItemDataTemplateSelector()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS // Issue: https://github.com/dotnet/maui/issues/34190

using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand Down Expand Up @@ -39,3 +41,4 @@ public void OnBackButtonPressedShouldFireForShellNavigationBarButton()
}
}
}
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,14 @@ public void BackButtonBehaviorTriggersWithCollectionView()
#if ANDROID || WINDOWS
App.TapBackArrow();
#elif IOS || MACCATALYST
App.TapBackArrow("Main");
if (App is AppiumIOSApp iosApp && HelperExtensions.IsIOS26OrHigher(iosApp))
{
App.TapBackArrow();
}
else
{
App.TapBackArrow("Main");
}
#endif

// Wait for navigation back and verify BackButtonBehavior was triggered
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading