[Android] Fix crash in GraphicsView when using TapGestureRecognizer#34301
Merged
PureWeen merged 2 commits intodotnet:mainfrom Mar 5, 2026
Merged
[Android] Fix crash in GraphicsView when using TapGestureRecognizer#34301PureWeen merged 2 commits intodotnet:mainfrom
PureWeen merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34301Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34301" |
Contributor
|
Hey there @@jpd21122012! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Member
|
/azp run maui-pr-uitests, maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
sheiksyedm
reviewed
Mar 4, 2026
Member
|
/azp run maui-pr-uitests, maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
approved these changes
Mar 4, 2026
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes a crash on Android when using
TapGestureRecognizerwithGraphicsView.Root Cause
PlatformTouchGraphicsView.TouchesMovedassumed that_lastMovedViewPointsalways contained at least one element.
In certain touch event sequences (triggered when a TapGestureRecognizer is attached),
_lastMovedViewPointscould be empty whilepoints.Length == 1,leading to an IndexOutOfRangeException.
Fix
Added a length check before accessing
_lastMovedViewPoints[0]to prevent out-of-range access.
Verified Scenarios
Fixes #34296