Workaround CoreCLR R2R integration test build failures on macCatalyst and Windows#34304
Draft
mattleibow wants to merge 1 commit intonet11.0from
Draft
Workaround CoreCLR R2R integration test build failures on macCatalyst and Windows#34304mattleibow wants to merge 1 commit intonet11.0from
mattleibow wants to merge 1 commit intonet11.0from
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34304Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34304" |
Contributor
There was a problem hiding this comment.
Pull request overview
Disables a single failing integration test scenario in Microsoft.Maui.IntegrationTests on the net11.0 branch to unblock CI while the underlying CoreCLR/R2R toolchain issues are tracked in #34303.
Changes:
- Commented out the
SimpleTemplateTest.BuildInlineData case that setsUseMonoRuntime=false EnablePreviewFeatures=true. - Added inline comments describing the failure modes and linking to the tracking issue.
src/TestUtils/src/Microsoft.Maui.IntegrationTests/SimpleTemplateTest.cs
Outdated
Show resolved
Hide resolved
mattleibow
force-pushed
the
fix/disable-coreclr-r2r-integration-test
branch
from
5bf8a51 to
4766ba0
Compare
mattleibow
changed the title
mattleibow
changed the title
mattleibow
force-pushed
the
fix/disable-coreclr-r2r-integration-test
branch
from
4766ba0 to
06574c9
Compare
mattleibow
changed the title
… and Windows CoreCLR R2R template builds fail for macCatalyst (R2R object has wrong linker version) and on Windows for iOS/macCatalyst (crossgen2 missing). Remove the macCatalyst and Windows TFMs from the generated project when UseMonoRuntime=false, keeping Android and iOS which build successfully. This needs to be fixed upstream in the .NET SDK/runtime toolchain. Workaround for #34303 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
force-pushed
the
fix/disable-coreclr-r2r-integration-test
branch
from
06574c9 to
5945c77
Compare
Contributor
|
might not be needed with #34237 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
The
SimpleTemplateTest.Buildintegration test withUseMonoRuntime=false EnablePreviewFeatures=true(CoreCLR R2R) fails to build on certain platform TFMs:Android, iOS (on macOS), and Windows TFMs build fine. This has been failing on every
net11.0build since Jan 27 (46/47 tests pass, this 1 fails), and causes the Windows job to timeout after ~2 hours.Workaround
This PR removes only the broken TFMs per platform so the test still validates CoreCLR R2R on the working ones:
The underlying issue needs to be fixed upstream in the .NET SDK/runtime toolchain.
Changes
SimpleTemplateTest.cs: WhenUseMonoRuntime=false, removes broken TFMs from the generated csproj before building. UsesOperatingSystem.IsWindows()to conditionally also remove iOS on Windows (where crossgen2 is missing for Apple targets).Issues
Workaround for #34303 — upstream fix needed in .NET SDK/runtime.