Skip to content

[Android]Fix TestDoesntCrashWithCachingDisable UI Test failure#34398

Merged
jfversluis merged 1 commit intodotnet:mainfrom
devanathan-vaithiyanathan:fix-test-failure-2354
Mar 11, 2026
Merged

[Android]Fix TestDoesntCrashWithCachingDisable UI Test failure#34398
jfversluis merged 1 commit intodotnet:mainfrom
devanathan-vaithiyanathan:fix-test-failure-2354

Conversation

@devanathan-vaithiyanathan
Copy link
Copy Markdown
Contributor

@devanathan-vaithiyanathan devanathan-vaithiyanathan commented Mar 10, 2026

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This pull request updates the image URLs used in the President objects within the Init() method of Issue2354.cs to ensure that they reference the correct raw image files directly from GitHub. This change improves reliability and consistency in how images are loaded for test cases.

Image URL updates:

  • Changed all image URLs for President objects to use the raw.githubusercontent.com domain, removing the ?raw=true query parameter and ensuring direct access to the image files.

Instead of:
https://github.com/.../avatar.png?raw=true

use the resolved target:
https://raw.githubusercontent.com/dotnet/maui/refs/heads/main/src/Controls/tests/TestCases.HostApp/Resources/Images/avatar.png

This removes the cross‑host redirect entirely and is the most robust option for in‑app fetching. The raw.githubusercontent.com which hosts the actual raw files.

References: Issue16032, Bugzilla35733, Bugzilla37625 has a url that used form raw.githuusercontent.

Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34398

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34398"

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Mar 10, 2026
@devanathan-vaithiyanathan devanathan-vaithiyanathan added the community ✨ Community Contribution label Mar 10, 2026
@sheiksyedm sheiksyedm marked this pull request as ready for review March 10, 2026 09:44
Copilot AI review requested due to automatic review settings March 10, 2026 09:44
@sheiksyedm
Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the HostApp repro page for Issue #2354 to use direct raw.githubusercontent.com URLs for the UriImageSource images, instead of GitHub blob/...?...raw=true links. This keeps the scenario internet-based while avoiding the GitHub “blob” indirection.

Changes:

  • Replace GitHub blob image URLs (...?raw=true) with direct raw.githubusercontent.com URLs for the same test images.

@PureWeen
Copy link
Copy Markdown
Member

/azp run maui-pr-uitests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis jfversluis merged commit a5d128d into dotnet:main Mar 11, 2026
158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants