[Android]Fix TestDoesntCrashWithCachingDisable UI Test failure#34398
Merged
jfversluis merged 1 commit intodotnet:mainfrom Mar 11, 2026
Merged
Conversation
Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34398Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34398" |
Contributor
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the HostApp repro page for Issue #2354 to use direct raw.githubusercontent.com URLs for the UriImageSource images, instead of GitHub blob/...?...raw=true links. This keeps the scenario internet-based while avoiding the GitHub “blob” indirection.
Changes:
- Replace GitHub
blobimage URLs (...?raw=true) with directraw.githubusercontent.comURLs for the same test images.
This was referenced Mar 10, 2026
Member
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This pull request updates the image URLs used in the
Presidentobjects within theInit()method ofIssue2354.csto ensure that they reference the correct raw image files directly from GitHub. This change improves reliability and consistency in how images are loaded for test cases.Image URL updates:
Presidentobjects to use theraw.githubusercontent.comdomain, removing the?raw=truequery parameter and ensuring direct access to the image files.Instead of:
https://github.com/.../avatar.png?raw=true
use the resolved target:
https://raw.githubusercontent.com/dotnet/maui/refs/heads/main/src/Controls/tests/TestCases.HostApp/Resources/Images/avatar.png
This removes the cross‑host redirect entirely and is the most robust option for in‑app fetching. The raw.githubusercontent.com which hosts the actual raw files.
References: Issue16032, Bugzilla35733, Bugzilla37625 has a url that used form raw.githuusercontent.