Add MauiXamlHotReload to the list of CompilerVisibleProperties#34405
Merged
StephaneDelcroix merged 2 commits intodotnet:mainfrom Mar 10, 2026
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34405Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34405" |
StephaneDelcroix
approved these changes
Mar 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures the MauiXamlHotReload MSBuild property is visible to Roslyn (via AnalyzerConfigOptions.GlobalOptions) by registering it as a compiler-visible property in the Controls build-transitive targets. This aligns with the intent of #34028 so IDE tooling and source generators can adapt behavior based on the configured XAML Hot Reload mode.
Changes:
- Add
MauiXamlHotReloadto theCompilerVisiblePropertyitem list in Controls’ common build targets.
Contributor
|
Hey there @@noiseonwires! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
pushed a commit
to kubaflo/maui
that referenced
this pull request
Mar 10, 2026
…t#34405) The MauiXamlHotReload MSBuild property was introduced in dotnet#34028 but was not registered as a compiler-visible property. Without this entry, Roslyn source generators cannot read the property value via AnalyzerConfigOptions.GlobalOptions. This change makes it accessible so IDE and source generators can adjust their behavior based on the configured hot reload mode (Legacy or SourceGen). Co-authored-by: Kirill Ovchinnikov <kovchinnikov@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MauiXamlHotReload MSBuild property was introduced in #34028 but was not registered as a compiler-visible property. Without this entry, Roslyn source generators cannot read the property value via AnalyzerConfigOptions.GlobalOptions. This change makes it accessible so IDE and source generators can adjust their behavior based on the configured hot reload mode (Legacy or SourceGen).