Remove stale PR note from Copilot instructions#34566
Merged
jfversluis merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
The dogfooding comment bot now automatically adds testing instructions to every PR, making this manual note redundant. Remove it from all Copilot instruction files so agents stop prepending it to PR descriptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34566Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34566" |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the previously hardcoded “test PR artifacts” NOTE block guidance from Copilot instruction/skill documentation, aligning the repo’s agent guidance with the new approach where a bot posts testing instructions automatically.
Changes:
- Removed the NOTE block requirement and template snippets from the
pr-finalizeskill documentation. - Updated the
pr-finalize“complete example” reference to no longer include the NOTE block. - Removed the “Opening PRs” section from
.github/copilot-instructions.mdthat mandated the NOTE block.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/skills/pr-finalize/SKILL.md |
Drops NOTE block requirement/examples (but still contains other NOTE-block mentions that should be updated for consistency). |
.github/skills/pr-finalize/references/complete-example.md |
Updates example PR description to remove the NOTE block section. |
.github/copilot-instructions.md |
Removes the “Opening PRs” NOTE-block mandate from general Copilot instructions. |
Comments suppressed due to low confidence (1)
.github/copilot-instructions.md:206
- The PR description says the stale PR note was removed from all Copilot instruction files, but there’s still a copy under
custom-instructions/repo/.github/copilot-instructions.mdthat contains the NOTE block and Testing-PR-Builds link. If that directory is used by tooling, it will keep reintroducing the stale guidance; otherwise consider deleting/clarifying its purpose.
- `.github/instructions/xaml-unittests.instructions.md` - XAML unit test guidelines
## Custom Agents and Skills
The repository includes specialized custom agents and reusable skills for specific tasks.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+130
to
+131
| 1. Include the base sections from `.github/PULL_REQUEST_TEMPLATE.md` ("Description of Change" and "Issues Fixed"). The skill adds additional structured fields (Root cause, Fix, Key insight, etc.) as recommended enhancements for better agent context. | ||
| 2. Match the actual implementation |
kubaflo
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the "Are you waiting for the changes in this PR to be merged?" note from all Copilot instruction files.
This note was previously required at the top of every PR description so users could find instructions on how to test PR artifacts. We now have a dogfooding comment bot that automatically posts testing instructions under each PR, making this manual note redundant.
Copilot agents were still prepending this note to every PR description because it was hardcoded in:
.github/copilot-instructions.md(main instructions).github/skills/pr-finalize/SKILL.md(PR finalization skill).github/skills/pr-finalize/references/complete-example.md(example PR)Issues Fixed
N/A — instruction cleanup only.