[Android] Clamp BottomNavigationView MaxItemCount to 5 for Material3 net11.0 compatibility

[Ahamed-Ali]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

On net11.0, the Material3 package (#33450) changed BottomNavigationView.MaxItemCount from 5 to 6. This caused Android Shell and TabbedPage bottom navigation rendering to change, breaking ~16 screenshot baselines on the net11.0 branch.

This PR clamps MaxItemCount back to 5 to maintain consistent behavior across .NET versions.

Code Changes

BottomNavigationViewUtils.cs:

• Added MaxBottomNavigationItems = 5 constant
• SetupMenu and CreateMoreBottomSheet both clamp maxBottomItems to this constant

ShellItemRenderer.cs:

• "More" tab logic and UpdateMenuItems now clamp MaxItemCount to 5, preventing more than 5 items in the bottom navigation bar

Snapshot Updates

Updated 16 Android screenshot baselines affected by the tab layout change:

• Shell appearance tests (tab bar colors, foreground, background, RTL)
• TabbedPage menu item tests
• Tab icon and visibility tests
• Flyout icon tests
• Navigation bar layout tests

Also updated:

• Material3TimePicker_InitialState_VerifyVisualState (android-notch-36)
• VerifyHybridWebViewWithShadow (ios-26)

Known Gaps

This PR does NOT update all affected snapshots. The following are known to still need baseline updates or investigation:

• Issue18896Test - confirmed 5.74% screenshot diff in the bottom nav area (same root cause, missing baseline update)
• 10 additional Shell/TabbedPage snapshots from [net11.0] Screenshot baseline mismatches after main merge (Shell, TabbedPage, Image, Flyout) #34586 that were intentionally left unchanged (bet: the code fix restores them to match existing baselines)

Root Cause

The Material3 package on net11.0 increased BottomNavigationView.MaxItemCount from 5 to 6. This changed the layout of bottom navigation tabs, causing extra space allocation and rendering differences in all tests that capture bottom navigation UI.

See: #33450

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34601

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34601"

[sheiksyedm]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Copilot]

Pull request overview

This PR enforces a consistent 5-item maximum for Android bottom navigation across .NET versions by clamping BottomNavigationView.MaxItemCount (notably when Material returns 6 on .NET 11), helping avoid UI/layout differences such as “More” tab behavior changes.

Changes:

• Clamp the max bottom navigation item count to 5 in BottomNavigationViewUtils.SetupMenu.
• Clamp the max item count to 5 when building the “More” bottom sheet in BottomNavigationViewUtils.CreateMoreBottomSheet.
• Clamp MaxItemCount usage in ShellItemRenderer for “More” tab / menu update logic.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/Controls/src/Core/Platform/Android/BottomNavigationViewUtils.cs	Clamps max bottom nav items to 5 for menu setup and “More” bottom sheet creation.
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellItemRenderer.cs	Clamps _bottomView.MaxItemCount to 5 where Shell computes “More” and updates menu items.

[sheiksyedm]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Copilot]

Pull request overview

Copilot reviewed 2 out of 20 changed files in this pull request and generated 1 comment.

[sheiksyedm]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Ahamed-Ali]

This is for the Known Build Issues
The AOT error on maui-pr will be fixed by this #34552

#34550 (comment)