Fix CI pipeline build warnings (RS0016/RS0017, XA1006, duplicate splash, XAML)#34629
Open
Fix CI pipeline build warnings (RS0016/RS0017, XA1006, duplicate splash, XAML)#34629
Conversation
- Fix RS0016/RS0017: Add [MAUIAI0001] prefix to PublicAPI.Unshipped.txt entries in Essentials.AI project (net-ios, net-maccatalyst, net-macos) to match assembly-level [Experimental] attribute (fixes 81 warnings) - Fix duplicate MauiSplashScreen in Essentials.AI.Sample.csproj (fixes 6 warnings across TFMs) - Fix XA1006/XA4211: Update GraphicsTester.Android targetSdkVersion from 31 to 36 to match TFM API level (fixes 4 warnings) - Fix XAML warning in TwoPaneViewPage.xaml: Move BackgroundColor attribute from property element to child Frame (fixes 6 warnings) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34629Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34629" |
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces recurring CI build warnings across MAUI solution builds by aligning platform metadata (Android manifest), fixing invalid XAML, and correcting PublicAPI analyzer expectations for an experimental assembly.
Changes:
- Add the
[MAUIAI0001]experimental diagnostic prefix to Essentials.AI PublicAPI unshipped entries for Apple TFMs to resolve RS0016/RS0017 warnings. - Update
GraphicsTester.AndroidmanifesttargetSdkVersionto match the repo’s current default Android API level and eliminate XA1006/XA4211 warnings. - Fix invalid XAML usage in
TwoPaneViewPage.xamland remove a duplicate splash screen item from the Essentials.AI sample project.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Graphics/samples/GraphicsTester.Android/Properties/AndroidManifest.xml | Updates targetSdkVersion to match current Android API level and stop related Android build warnings. |
| src/Controls/samples/Controls.Sample/Pages/Others/TwoPaneViewPage.xaml | Corrects invalid property-element attribute usage by moving BackgroundColor to a valid element. |
| src/AI/src/Essentials.AI/PublicAPI/net-macos/PublicAPI.Unshipped.txt | Prefixes unshipped APIs with the experimental diagnostic ID to satisfy PublicAPI analyzers. |
| src/AI/src/Essentials.AI/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt | Same experimental prefix fix for MacCatalyst PublicAPI entries. |
| src/AI/src/Essentials.AI/PublicAPI/net-ios/PublicAPI.Unshipped.txt | Same experimental prefix fix for iOS PublicAPI entries. |
| src/AI/samples/Essentials.AI.Sample/Essentials.AI.Sample.csproj | Removes a duplicate MauiSplashScreen item that was causing warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes ~97 build warnings that appear on every PR pipeline run (visible in the CI build logs for
Build Microsoft.Maui.slnsteps).Changes
PublicAPI.Unshipped.txtentries in Essentials.AI were missing the[MAUIAI0001]prefix required by the assembly-level[Experimental("MAUIAI0001")]attribute. Added prefix to all entries in net-ios, net-maccatalyst, net-macos.Essentials.AI.Sample.csprojhad twoMauiSplashScreenentries (same SVG, different colors). Removed duplicate.GraphicsTester.AndroidAndroidManifest.xmlhadtargetSdkVersion=31but TFM targets API 36. Updated to 36.TwoPaneViewPage.xamlhadBackgroundColorattribute on property elementPane1(invalid, ignored at runtime). Moved to childFrame.Not addressed (intentional/external)
Controls.Xaml.UnitTeststest project (configured viaWarningsNotAsErrors)Gee.External.Capstone) 16KB page alignment warning in benchmarks