Skip to content

[iOS] Fix Issue23377ItemSpacing test failure on candidate branch #34750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubaflo merged 1 commit into from
Mar 31, 2026
+7 −0
Merged

[iOS] Fix Issue23377ItemSpacing test failure on candidate branch #34750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Controls/src/Core/Handlers/Items2/iOS/ItemsViewController2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,20 @@ public void UpdateLayout(UICollectionViewLayout newLayout)
ScrollDirection = compositionalLayout.Configuration.ScrollDirection;
}

// Preserve the content offset before updating the layout.
// SetCollectionViewLayout with animated:false can unexpectedly shift the content offset
// on UICollectionViewCompositionalLayout with estimated item sizes.
var savedOffset = CollectionView.ContentOffset;

ItemsViewLayout = newLayout;
_initialized = false;

EnsureLayoutInitialized();

if (_initialized)
{
// Restore the content offset that may have been changed by SetCollectionViewLayout
CollectionView.ContentOffset = savedOffset;
// Reload the data so the currently visible cells get laid out according to the new layout
ReloadData();
}
Expand Down
Loading