Add drag-drop item reordering to CollectionView #3767#3768
Merged
hartez merged 4 commits intodotnet:mainfrom Feb 1, 2022
Merged
Add drag-drop item reordering to CollectionView #3767#3768hartez merged 4 commits intodotnet:mainfrom
hartez merged 4 commits intodotnet:mainfrom
Conversation
pictos
reviewed
Jan 27, 2022
|
|
||
| public interface IGroupableItemsViewSource : IItemsViewSource | ||
| { | ||
| (int, int) GetGroupAndIndex(int position); |
Contributor
There was a problem hiding this comment.
Can you label those ints in the ValueTuple? To be more explicit on what those means, like (int x, int y)
Contributor
Author
There was a problem hiding this comment.
Sure! I just committed the change.
hartez
approved these changes
Feb 1, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Implements drag-drop item reordering for CollectionView #3767
Additions made
CollectionViewtoReorderableItemsView.CanReorderItemsproperty toReorderableItemsView.CanMixGroupsproperty toReorderableItemsView.ReorderCompletedevent toReorderableItemsView.Pictures
PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.