Skip to content

[Windows] [Shell] Fix Flyout Background so it gets set in Locked behavior mode#6901

Merged
PureWeen merged 5 commits intomainfrom
fix-6552
May 7, 2022
Merged

[Windows] [Shell] Fix Flyout Background so it gets set in Locked behavior mode#6901
PureWeen merged 5 commits intomainfrom
fix-6552

Conversation

@rachelkang
Copy link
Copy Markdown
Member

@rachelkang rachelkang commented May 6, 2022

Description of Change

On Windows, the background color was not getting applied to the Flyout menu when started up with Locked behavior.
Now, by updating the value on loaded, it does! Yay :)

Issues Fixed

Fixes #6552
Fixes #6244

@rachelkang rachelkang requested a review from PureWeen May 6, 2022 16:32
@rachelkang rachelkang added platform/windows area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels May 6, 2022
@rachelkang rachelkang changed the title Fix Flyout Background logic so it gets set in Locked behavior mode [Windows] [Shell] Fix Flyout Background so it gets set in Locked behavior mode May 6, 2022
@rachelkang rachelkang added this to the 6.0.300 milestone May 6, 2022
@PureWeen PureWeen merged commit d20a808 into main May 7, 2022
@PureWeen PureWeen deleted the fix-6552 branch May 7, 2022 00:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.312 Look for this fix in 6.0.312! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.312 Look for this fix in 6.0.312! platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shell flyout background color does not change when behavior is set to Locked Shell AppThemeBinding is incorrect and not consistent

3 participants