Merged
Conversation
…/essentials-unpackaged
mattleibow
commented
Jul 6, 2022
Comment on lines
+717
to
+734
| <ItemGroup> | ||
| <AssemblyAttribute Include="System.Reflection.AssemblyMetadataAttribute"> | ||
| <_Parameter1>Microsoft.Maui.ApplicationModel.AppInfo.PackageName</_Parameter1> | ||
| <_Parameter2>@(_MauiAppxManifestIdentity)</_Parameter2> | ||
| </AssemblyAttribute> | ||
| <AssemblyAttribute Include="System.Reflection.AssemblyMetadataAttribute"> | ||
| <_Parameter1>Microsoft.Maui.ApplicationModel.AppInfo.PublisherName</_Parameter1> | ||
| <_Parameter2>@(_MauiAppxManifestPublisher)</_Parameter2> | ||
| </AssemblyAttribute> | ||
| <AssemblyAttribute Include="System.Reflection.AssemblyMetadataAttribute"> | ||
| <_Parameter1>Microsoft.Maui.ApplicationModel.AppInfo.Name</_Parameter1> | ||
| <_Parameter2>@(_MauiAppxManifestDisplayName)</_Parameter2> | ||
| </AssemblyAttribute> | ||
| <AssemblyAttribute Include="System.Reflection.AssemblyMetadataAttribute"> | ||
| <_Parameter1>Microsoft.Maui.ApplicationModel.AppInfo.Version</_Parameter1> | ||
| <_Parameter2>@(_MauiAppxManifestVersion)</_Parameter2> | ||
| </AssemblyAttribute> | ||
| </ItemGroup> |
Member
Author
There was a problem hiding this comment.
Add the various properties to the dll as metadata so we can use them in unpackaged apps which have no manifest and no way of knowing what app it is.
Comment on lines
+15
to
+16
| static string AppSpecificPath => | ||
| Path.Combine(CleanPath(AppInfoImplementation.PublisherName), CleanPath(AppInfo.PackageName)); |
Member
Author
There was a problem hiding this comment.
In all honesty, this is not so great because the app ID is a GUID, which means the AppData folder will end up with a bunch of GUIDs. But, that is also what is in the C:\ProgramData\Packages folder and that is where all the MSIX apps put things. So not a machine issue - more a user issue.
41 tasks
Member
Author
|
Moved the unnecessary changes to #8748 |
mattleibow
added
platform/windows
area-essentials
This was referenced Aug 11, 2022
This was referenced Aug 25, 2022
samhouts
added
fixed-in-7.0.0-rc.1.6683
fixed-in-6.0.486
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
More work on reaching the goal of all APIs working in unpackaged apps.
This makes the following APIs work:
Issues Fixed
Part of the larger #3166
Fixes some of #8552