-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix localization setup for release branches #8838
Copy link
Copy link
Closed
Labels
Area: Our Own BuildProblems affecting the build or build infrastructure of the MSBuild repo itself.Problems affecting the build or build infrastructure of the MSBuild repo itself.Good First IssueSelf-contained issues good for first-time contributors.Self-contained issues good for first-time contributors.triaged
Metadata
Metadata
Assignees
Labels
Area: Our Own BuildProblems affecting the build or build infrastructure of the MSBuild repo itself.Problems affecting the build or build infrastructure of the MSBuild repo itself.Good First IssueSelf-contained issues good for first-time contributors.Self-contained issues good for first-time contributors.triaged
Type
Fields
Give feedbackNo fields configured for issues without a type.
Background
MSBuild is at times getting flood of self negating commits in OneLocBuild PRs.
Rootcause
This is apparently caused by main and some release branches sharing the same localization
PackageIdand even branch - e.g.vs17.2specifies the condition for self, butmirrorBranchasmain: https://github.com/dotnet/msbuild/blob/vs17.2/.vsts-dotnet.yml#L45-L51What needs to be done
Official info: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches
Option 1 - use the localization only in
main, and temporarily flip it on release only if some localization string was changed thereOption 2:
I'd strongly recomend agains Option 1 - as it's prone to easily missed overlooks and forgeting (it's likely what got us in current situation).
Related information