Skip to content

Fix localization setup for release branches #8838

@JanKrivanek

Description

@JanKrivanek

Background

MSBuild is at times getting flood of self negating commits in OneLocBuild PRs.

Rootcause

This is apparently caused by main and some release branches sharing the same localization PackageId and even branch - e.g. vs17.2 specifies the condition for self, but mirrorBranch as main: https://github.com/dotnet/msbuild/blob/vs17.2/.vsts-dotnet.yml#L45-L51

What needs to be done

Official info: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches
Option 1 - use the localization only in main, and temporarily flip it on release only if some localization string was changed there
Option 2:

  • create ticket with localization team to ask for second project for release branches (or main)
  • update the pipline code to properly condition based on branch name and specify correct branch and appropriate localization id

I'd strongly recomend agains Option 1 - as it's prone to easily missed overlooks and forgeting (it's likely what got us in current situation).

Related information

Metadata

Metadata

Assignees

Labels

Area: Our Own BuildProblems affecting the build or build infrastructure of the MSBuild repo itself.Good First IssueSelf-contained issues good for first-time contributors.triaged

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions