Skip to content

[LiveLogger] Only show indicators for projects where relevant#8617

Closed
edvilme wants to merge 2 commits intodotnet:mainfrom
edvilme:edvilme-ll-red
Closed

[LiveLogger] Only show indicators for projects where relevant#8617
edvilme wants to merge 2 commits intodotnet:mainfrom
edvilme:edvilme-ll-red

Conversation

@edvilme
Copy link
Copy Markdown
Contributor

@edvilme edvilme commented Mar 31, 2023

Fixes #8456

Context

For each project, details regarding amount of messages, warnings and errors are shown. However, this information must be hidden where it is not relevant.

Changes Made

Add the ℹ️, ⚠️, ❌ output only when is >0 (for each of the three).

Testing

Manual testing

Notes

@edvilme
Copy link
Copy Markdown
Contributor Author

edvilme commented Mar 31, 2023

@dotnet-policy-service agree

@rainersigwald
Copy link
Copy Markdown
Member

Hey @edvilme! We've taken a small reset on LiveLogger while we reevaluate some of the design goals, so we're probably not going to take this right away. When we have a bit more clarity on what we want to do we'll try to be clear about writing it down . . .

@rainersigwald
Copy link
Copy Markdown
Member

The changes in #8619 will supersede this, so I'm going to close it. Soon we'll have daily SDK builds with the new bits to try out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LiveLogger] Don't render any yellow or red unless/until there is a warning/error

2 participants