Remove unreachable and unused overload methods from IntrinsicFunctions#8649
Remove unreachable and unused overload methods from IntrinsicFunctions#8649jrdodds wants to merge 1 commit intodotnet:mainfrom
Conversation
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good - dead code removal
|
rainersigwald commented this morning that our documentation says we support longs and made a pigeonhole argument that supporting doubles does not obviate the need to support long. Indeed, I made a very simple test project (see #8698) that demonstrates that MSBuild is indeed flawed in this respect. We're currently not 100% clear on whether we can take this change and just change how we parse the numbers or if we need to explicitly call these overloads but currently aren't. |
|
This issue of the unsupported overloads came up in the discussion for #8569 but it is 'new' in this discussion that |
|
Negated by #8710 |
Fixes # (issue to be created)
Context
This is a change that was split out from PR #8569 at the request of @rainersigwald.
The change removes type overload methods from
IntrinsicFunctionsthat are unreachable via evaluation and that are unused within the repo.This is cleanup that could support a future effort to add source generation for the 'fast path' lookup.
Changes Made
Remove
longvariants ofAdd,Subtract,Multiply,Divide, andModulo. Evaluation will always use thedoublevariants.Testing
Built and ran unit tests on Windows 11 and macOS 12.
Notes