add ConfigurationManager to Version.Details#8818
Conversation
|
@rainersigwald soft ping - would be great if you could take a look at this small PR for source-build. Thank you for your time! |
rainersigwald
left a comment
There was a problem hiding this comment.
We have several other runtime dependencies that feel like they might be similar. Should they be added here? If not, how can we tell?
Lines 29 to 43 in f3dcaf7
In most cases addition of these kind of entries to Currently only |
Context
Contributes to dotnet/source-build#3043
Declaring the
System.Configuration.ConfigurationManagerdependency inVersion.Details.xmlwill allow source-build to replace the currently used7.0.0version with then-1version coming from previously source-built artifacts in the product / VMR build.Without this change, once repo PvP is enabled, the source-build of
msbuildwill fail in the product build.Changes Made
System.Configuration.ConfigurationManager: 7.0.0toVersion.Details.xmlTesting
Notes