Skip to content

Improve waiting for the server is in use by the signal that a marker file is created by the build task#8981

Merged
GangWang01 merged 2 commits intodotnet:mainfrom
GangWang01:flaky-test
Jul 21, 2023
Merged

Improve waiting for the server is in use by the signal that a marker file is created by the build task#8981
GangWang01 merged 2 commits intodotnet:mainfrom
GangWang01:flaky-test

Conversation

@GangWang01
Copy link
Copy Markdown
Member

@GangWang01 GangWang01 commented Jun 30, 2023

Fixes #8956

Context

#8956 (comment)

Changes Made

Improve waiting for the server is in use by the signal that a marker file is created by the build task.

Testing

Notes

@GangWang01 GangWang01 marked this pull request as ready for review June 30, 2023 09:21
Copy link
Copy Markdown
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generally not a good idea to have timeouts like this, or to increase them without detailed data indicating why.

Is it possible to get a distinct signal from the second process that it's going, perhaps a line on stdout or a file that acts as a marker?

@GangWang01 GangWang01 changed the title Stabilize the test by increasing the waiting time for starting long-live task Improve waiting for the server is in use by the signal that a marker file is created by the build task Jul 5, 2023
@GangWang01
Copy link
Copy Markdown
Member Author

GangWang01 commented Jul 5, 2023

It's generally not a good idea to have timeouts like this, or to increase them without detailed data indicating why.

Is it possible to get a distinct signal from the second process that it's going, perhaps a line on stdout or a file that acts as a marker?

Thanks for the suggestion! It's possible to let the build task create a marker file as the signal.

Copy link
Copy Markdown
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so much better!

Comment thread src/MSBuild.UnitTests/MSBuildServer_Tests.cs
Comment thread src/MSBuild.UnitTests/MSBuildServer_Tests.cs Outdated
Copy link
Copy Markdown
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now looks much more solid then the original test - thanks!

@GangWang01 GangWang01 requested a review from rainersigwald July 14, 2023 10:25
@GangWang01 GangWang01 merged commit 59b15c1 into dotnet:main Jul 21, 2023
@GangWang01 GangWang01 deleted the flaky-test branch July 21, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test - MSBuildServerTest

3 participants