Improving the log of CombineTargetFrameworkInfoProperties fails with not valid RootElementName

[JaynieBai]

Fixes #8320

Context

CombineTargetFrameworkInfoProperties) is not handling null case of RootElementName. And empty RootElementName when UseAttributeForTargetFrameworkInfoPropertyNames is false.

Changes Made

Add the verification with the name of the parameter.

Testing

RootElementNameNotValid()

Notes

[rainersigwald]

While the MSBuild engine handles exceptions thrown from tasks and provides a generic error message, it's almost always better to log an explicit error from the task instead of throwing an exception. It's easier to understand, you can provide more information about the specific failure, and it can get a unique error code.

Can you please rewrite to use that approach?

[JaynieBai]

While the MSBuild engine handles exceptions thrown from tasks and provides a generic error message, it's almost always better to log an explicit error from the task instead of throwing an exception. It's easier to understand, you can provide more information about the specific failure, and it can get a unique error code.

Can you please rewrite to use that approa

While the MSBuild engine handles exceptions thrown from tasks and provides a generic error message, it's almost always better to log an explicit error from the task instead of throwing an exception. It's easier to understand, you can provide more information about the specific failure, and it can get a unique error code.

Can you please rewrite to use that approach?

Done

[JanKrivanek]

Looks good to me!