Skip to content

Ship BuildXL assemblies in our VSIX#9185

Merged
rainersigwald merged 3 commits intomainfrom
exp/bxl-setup-authoring
Aug 30, 2023
Merged

Ship BuildXL assemblies in our VSIX#9185
rainersigwald merged 3 commits intomainfrom
exp/bxl-setup-authoring

Conversation

@rainersigwald
Copy link
Copy Markdown
Member

New dependencies added in #8726 weren't being deployed to VS. Ship them once (rooted in MSBuild\bin) and add binding redirects for the 64-bit versions to use it from there.

Because BuildXL is not pushed to nuget.org, it's an inconvenient
dependency. But it's not required for API completion so mark it
as a private dependency--it can be satisified by the VS install.
Copy link
Copy Markdown
Contributor

@dfederm dfederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually by deleting the relevant binaries from amd64\* and adding the app config changes.

@rainersigwald rainersigwald merged commit 0974273 into main Aug 30, 2023
@rainersigwald rainersigwald deleted the exp/bxl-setup-authoring branch August 30, 2023 02:00
@rainersigwald rainersigwald mentioned this pull request Aug 30, 2023
rainersigwald added a commit to rainersigwald/msbuild that referenced this pull request Aug 30, 2023
rainersigwald added a commit that referenced this pull request Aug 30, 2023
* Revert "Ship BuildXL assemblies in our VSIX and not our NuGet packages (#9185)"

This reverts commit 0974273.

* Revert "Merge pull request #8726 from dfederm/project-cache-vnext"

This reverts commit 462a917, reversing
changes made to 5958b59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants