[ClickOnce] Consider CopyToPublishDirectory property before publishing Content Items.#9486
Merged
JanKrivanek merged 2 commits intodotnet:vs17.9from Jan 18, 2024
Merged
Conversation
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
sujitnayak
force-pushed
the
user/sujitn/1921153
branch
from
0247baa to
18d6582
Compare
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
Do you want to take this for 17.9 QB mode? If so we'll need the paperwork . . .
Contributor
Author
Most likely since today is the last day for M2 approvals and the change I am making for the CR will incur another test pass. |
Contributor
Author
Bug has been updated with the QB mode template. |
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
JanKrivanek
approved these changes
Jan 18, 2024
YuliiaKovalova
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
AB#1921153
Summary
For Blazor apps, ClickOnce is publishing the staticwebassets.json file which is marked as CopyToPublishDirectory = Never. There are local paths in this json file so when the app is installed on a different machine where the local paths don't exist, the app crashes on launch.
Changes Made
Now when we determine the Content Items to publish, we look at the CopyToPublishDirectory metadata and exclude items that have it set to Never.
Customer Impact
Customers with Blazor Apps using ClickOnce to publish are seeing a failure to launch the app after upgrading to 17.8. Due to ClickOnce changes we made in 17.8 as part of PR 9299, we are incorrectly publishing the staticassets.json file. This is being addressed in this PR.
Regression?
Yes
Testing
Blazor app publishing scenario verified.
CTI team has done a regression test pass with the private.
Risk
Low