Logger emits message on invalid property name#9570
Merged
maridematte merged 4 commits intodotnet:mainfrom Jan 4, 2024
Merged
Conversation
Forgind
approved these changes
Dec 21, 2023
Contributor
Forgind
left a comment
Forgind
left a comment
There was a problem hiding this comment.
Thanks for resolving this! Nice, elegant solution 🙂
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Oct 15, 2025
Closed
Closed
This was referenced Oct 26, 2025
This was referenced Nov 13, 2025
Closed
This was referenced Nov 16, 2025
This was referenced Nov 23, 2025
Closed
This was referenced Dec 1, 2025
This was referenced Dec 9, 2025
Open
This was referenced Dec 24, 2025
This was referenced Jan 30, 2026
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9475
Context
When a property name is an invalid input, we log the error and shutdown the loggers when terminating the process. However, we did not flush the logs of any messages being processed before shutting down, making we miss this specific error in the process.
Changes Made
Added a wait for loggers to finish doing their work before shutting down.
Testing
Added a test to make sure that the logger emits the message before shutdown.